It was a bit difficult for me to understand how to make the difference..." is a natural way to express having trouble grasping how to differentiate between the mobile and desktop configurations initially.
Hassan Moataz
@hassanmoaaAll comments
- @DorEinhornSubmitted 9 months agoWhat challenges did you encounter, and how did you overcome them?@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is recommended to use rems and ems.
font-size: 13px;
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Heading is defined with
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6><h1>
to<h6>
tags. It is important to use headings to show the HTML document structure.Other than that you're good, keep up the good work!
0 - @hichamweblogSubmitted 9 months agoWhat are you most proud of, and what would you do differently next time?
Hi everyone,
I've finished this Frontend Mentor challenge using HTML and CSS.
What challenges did you encounter, and how did you overcome them?I tried to make it accessible and responsive.
What specific areas of your project would you like help with?Do you have any suggestions for improvements or optimizations?
Thanks!
@hassanmoaaPosted 9 months agoHello !
Great Job solving the challenge mate congrats π
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Heading is defined with
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6><h1>
to<h6>
tags. It is important to use headings to show the HTML document structure.Other than that you're good, keep up the good work!
0 - @crssbonaSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is recommended to use rems and ems.
font-size: 13px;
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Heading is defined with
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6><h1>
to<h6>
tags. It is important to use headings to show the HTML document structure.Other than that you're good, keep up the good work!
Marked as helpful0 - @lumbagooSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
ββββββββ
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Other than that you're good, keep up the good work!
0 - @DavidososeSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is recommended to use rems and ems.
font-size: 13px;
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Other than that you're good, keep up the good work!
Marked as helpful0 - @anand777sharmaSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is recommended to use rems and ems.
font-size: 13px;
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use
<main>
to wrap the main content instead of<div>
. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.βββββββ
Heading is defined with
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6><h1>
to<h6>
tags. It is important to use headings to show the HTML document structure.Other than that you're good, keep up the good work!
1 - @gio-cmdSubmitted 9 months ago
:))
@hassanmoaaPosted 9 months agoHello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is better to use rems and ems.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use <main> to wrap the main content instead of <div>. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
βββββββ
Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>Other than that you're good, keep up the good work!
0 -
- @BiancaPuglisiSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is better to use rems and ems.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use <main> to wrap the main content instead of <div>. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
βββββββ
Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>Other than that you're good, keep up the good work!
Marked as helpful0 -
- @amir2501Submitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is better to use rems and ems.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
ββββββββ
Use <main> to wrap the main content instead of <div>. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
ββββββ
Other than that you're good, keep up the good work!
Marked as helpful1 -
- @alone-as-a-godSubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
Use <main> to wrap the main content instead of <div>. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
βββββββ
Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>Other than that you're good, keep up the good work!
Marked as helpful0 - @Rahimjon-ASubmitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
For the font-size it's is better to use rems and ems.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
βββββββ
Other than that you're good, keep up the good work!
Marked as helpful1 -
- @Asrithareddy19Submitted 9 months ago@hassanmoaaPosted 9 months ago
Hello !
Great Job solving the challenge mate congrats π
Some suggestions for improvements.
Use <main> to wrap the main content instead of <div>. * π Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
βββββββ
Other than that you're good, keep up the good work!
Marked as helpful0