haru-kunyo
@haru-kunyoAll comments
- @KaikunmidevSubmitted 18 days agoP@haru-kunyoPosted 17 days ago
Great job on completing the challenge!!!
Your card looks really good. But i would like to suggest some changes:
1.HTML CODE:
using semantic html would be a better way for SEO, screeen readers have a easier time finding what to read and respond and finally meaningfull tags help better maintain the code
2.CSS CODE:
change the css it has lots of classes that can be condensed if semantic html is used istead of using a lots of divs.
Also the padding margins of the card seems a bit off it would be better if they are little symmetric and the font size can be reduced for certain parts to make it more accurate to the original
Keep up the good work!0 - @shantanusoni72Submitted 18 days agoP@haru-kunyoPosted 18 days ago
Great job on completing the challenge!!! your layout looks really accurate to the provided design. I noticed the margin and padding of the paragraphs are a bit off compared to the design and also the border radius of the qr code it a little too much. Maybe adjusting these will make it look more accurate to the design. Keep up the good work!
0