All comments

• 

  Chyunjet•620

  @JetyunSubmitted almost 2 years ago

  1. i think my tailwind doesn't generate because i can't upload the node modules into github, any way to solve this?
  2. The social icon, i can only change the color of border when i hover on it, but the icon, how to change the color?

  Please critisize it, it is my first attempt of using Tailwind

  

  Tailwind, flexbox

  1

  20
  

  Haroon Mustafa•80

  @haroon-rajaPosted almost 2 years ago

  Hi, First thing I notice is that you should change your stylesheet link path in the html to <link rel="stylesheet" href="./dist/output.css"> OR

  <link rel="stylesheet" href="dist/output.css"> this

  1
• 

  jaxjavate13•80

  @jaxjavate13Submitted almost 2 years ago

  

  QR Code Component using CSS Flexbox

  1

  10
  

  Haroon Mustafa•80

  @haroon-rajaPosted almost 2 years ago

  Hi there! Your solution looks great! I'm at quite a beginner level in frontend development myself, but I noticed that you are not using semantic HTML elements and second thing is that In CSS you should use relative units instead of absolute units means you should use rem or em units instead of px units because of accessibility reasons.

  Here are the links that you can learn about semantic elements and relative units:

  Semantic Elements

  Tutorials about px vs rem units

  Hope this helps you :) Good luck

  Marked as helpful

  0