Guek Ling
@gueklingAll comments
- @jjewelesSubmitted almost 3 years ago@gueklingPosted almost 3 years ago
Hi Justin, great work you've done there! Here are some suggestions I have:
(a) I notice that your site isn't responsive. It looks great on web, but is a little too large on mobile. Perhaps you can look into media queries to turn your site responsive.
(b) It seems that you're having some difficulties with the hover states for interactive elements. I was stuck on them for a long time too! For the image hover, perhaps you can check out this StackOverflow answer; it helped me a lot when I was doing this challenge.
(c) To solve some of the issues reported, you can add alternate text to your image. If you find it unnecessary, an empty alternate text would work too. For example:
<img src="./images/icon-ethereum.svg" alt="">
Good luck!
Marked as helpful0 - @mafi328Submitted almost 3 years ago
I could use any feedback really :D
@gueklingPosted almost 3 years agoYour solution looks amazing! Just one thing to point out - you have a
<header>
within another<header>
, which is causing most of the accessibility issues. You might want to do something like this instead:<header> <div class="name-of-img-class"></div> </header>
Good luck! :D
Marked as helpful0