Skip to content
OverviewSolutions
4
Comments
7
Greta
@gretagr

All comments

  • Greta•340
    @gretagrPosted almost 5 years ago

    Hi, your desktop version looks really nice! Do you plan to make it responsive? This would definitely improve your project :)

    1
  • Greta•340
    @gretagrPosted almost 5 years ago

    Hey, congrats on your first solution! I think your code is actually quite neat! You use HTML5 tags really nicely! (maybe you don't need the div's around article tags tho). However, I have some thoughts about the design itself:

    1. Your cards are way too big.
    2. There is no spacing around cards when the screen gets smaller.
    3. Heading text overlaps text below it on a mobile screen, and cards do not fit the screen.
    4. As mentioned before - you forgot to use given fonts.

    Now, it might seem to be not so much of an issue (the code is good, right?), but as a frontend developer, your goal is to get the website looking as close to the design as possible, so I thought this kind of feedback might be useful too :)

    Good luck on your next projects, you're off with a good start!

    1
  • Greta•340
    @gretagrPosted almost 5 years ago

    Hello, congrats on your first solution! Now, for the responsiveness. You can make this site responsive with bootstrap (since you already using it).

    All you need is to use responsive breakpoints (Bootstrap grid)

    Here is the link to the documentation, to get you started: https://getbootstrap.com/docs/3.4/css/#grid-options

    And video tutorial for extra clarity: https://www.youtube.com/watch?v=qmPmwdshCMw

    Good luck!

    1
  • Greta•340
    @gretagrPosted about 5 years ago

    Hey, it seems you added bad links for your code and live view. You can fix that by going to your solution, clicking thee dots near the name of the solution and selecting "edit solution".

    Your work deserved to be seen!

    0
  • Greta•340
    @gretagrPosted about 5 years ago

    Such a clean, beautiful solution! It makes me wanna try Bulma! Did you try it for the first time in this project?

    1
  • macbrightie•70
    @macbrightieSubmitted about 5 years ago

    this is the mobile version of the site .. please go through and tell me what you think... the mobile version has been corrected i have now added the desktop version please check that also and tell me what you think

    html, css, bootstrap, javascript & jquery

    1
    Greta•340
    @gretagrPosted about 5 years ago

    Hi, you did an amazing job so far!

    I have some ideas about how you could improve your project:

    The website has a horizontal scroll when viewing on the mobile. I think fixed body size is the reason for that (width: 405px). Also, you should always use the <meta> viewport element for responsive websites to avoid this kind of problem.

    The second one is absolutely a matter of taste: background for the menu (when active) could be less transparent so that the site beneath it wouldn't distract viewers' eyes so much.

    0