gonzzdev
@gonzzdevAll comments
- @vasanthmuthojuSubmitted 4 months ago@gonzzdevPosted 3 months ago
You're killing it! The only thing I would add is to pay attention to font sizes and spacing. for example you could've added letter-spacing to the "PERFUME" text.
0 - @temesgen-982Submitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
Placing the image properly.
@gonzzdevPosted 3 months agoYour code is easy to read and well organized. I would use a <span> tag and style it instead of the <strong> tag.
Marked as helpful0 - @ArcloanSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?Sizing the text correctly and the sizing of items in general.
What specific areas of your project would you like help with?If anyone can give me the feedback on the overall work or some tips for the sizing of the content it will be really appreciated. Thank you :)
@gonzzdevPosted 6 months agoHey there! 👌🏽
That's an awesome solution! I would recommend to use margin and change padding to change the space between objects. You can also use the imported weights for your fonts.
For example:
.description { color: var(--white); font-size: 13px; font-weight: 300; padding-top: 20px; padding-bottom: 20px; }
0 - @vi-almeida-designSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I did this far quicker than the 1st challenge. It also seems like everything is alright, at least visually speaking, so it's a good solution. There's probably things to improve on code-wise but I'm happy with the result.
What challenges did you encounter, and how did you overcome them?None this time around.
What specific areas of your project would you like help with?Any way in which I could shorten or streamline my code.
- @Randomgituser69Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Proud of making it similar to what it looks in the picture of the design. Though I'd apologize for the photo not loading for some reason. Idk why it didn't it load. Btw not sure what would i do differently next time
What challenges did you encounter, and how did you overcome them?I was struggling with putting the card to the center but when i set the display to grid,place content, place items to center then it's fixed
What specific areas of your project would you like help with?Guys how can i fix html img not showing on GitHub repository? Adding ./images/ to the href didn't even work. How do i fix it please please? I've never been so angry over this
@gonzzdevPosted 6 months agoHey there!
Here are some steps on how to import your image.
- Go to your GitHub repo (https://github.com/Randomgituser69/Qr-code-component-)
- Click on add file and drag the file to your repository.
- Edit your index.html file to add image using:
<img src="image-name.png" />
0