Skip to content
OverviewSolutions
4
Comments
5
Gomes Martins
@gomesemog

All comments

  • Gomes Martins•60
    @gomesemogPosted over 2 years ago

    Boa :)

    1
  • Gomes Martins•60
    @gomesemogPosted over 2 years ago

    Hello Brian! That's a good work overall bro, but you should pay attention to the typography that the challenges provide you to use, go to the styles-guide doc inside the folder to see things as colors, typo, etc. It helps a lot and make things much easier and close to the original solution.

    They also provide the font-size pattern you should be applying in your solution.

    be good!

    Marked as helpful
    0
  • Gomes Martins•60
    @gomesemogPosted over 2 years ago

    Kevin Powell's channel on youtube has some good tips and advice for when to use px, rem, em or %. He also have a ~20 days free course in his website which explains responsivity very clearly: https://courses.kevinpowell.co/view/courses/conquering-responsive-layouts/. It's very good, but you can not take the full course in one day, you have to wait day by day

    Also, for this specific project, I don't recommend to wrap the divs like you did before it turns in one column-design

    1
  • Axurynn•200
    @AxurynnSubmitted over 2 years ago

    I added a feature: be able to modify the qr code on the fly. On firefox, color input does not work properly at first use. You must click on a color square before you can completely custom the color. On chrome, I think everything works well :)

    qr_code_component

    3
    Gomes Martins•60
    @gomesemogPosted over 2 years ago

    nice :)

    0
  • Gomes Martins•60
    @gomesemogPosted over 2 years ago

    Great job my friend! I would second Caio's comment, its very useful. Other thing that I would point is that you centralized all the content, but it should be attribuited just for the card itself. Otherwise, again, great job!

    1