All comments

• 

  Farhan Ali Bhat• 10

  @ifarhanaly

  Submitted 11 months ago

  "Hi, I would greatly appreciate your feedback on my First project. Please feel free to share your thoughts and suggestions. Thank you in advance for your input!"

  

  QR-code-component using HTML,CSS

  1

  50

  

  Gonzalo M. Núñez• 110

  @gnunez0101

  Posted 11 months ago

  Hello Farhan Ali,

  I took a look to your solution and seems really good. I have some comments about it:

  1. You used Calibri font for the solution. Looks good, but, the requested font was Outfit. Remember, for frontend development attention to details are everything. Use the requested font to get a closer appereance to design.
  2. It would be nice to use CSS custom properties. At least for the colors. This will make code more reusable.
  3. If you are using Flexbox, prefer align-items and justify-content for centering items instead of text-align: center. They work better and never fail.
  4. You are centering vertically with padding and margin. Use align-items for better results.
  5. For next solutions replace the link in "Coded by" with your profile's link. You left the # from the template.

  I hope this notes can help you improve your next challenges.

  Have a nice coding,

  Gonzalo.

  0