@dev-paulLSubmitted 4 months ago
What specific areas of your project would you like help with?
Accessiblity, and making good use of the clamp() and calc().
P
gmdpickett
@gmdpickettAll comments
- @gmdpickettPosted 4 months ago
Great work on this challenge, so close to the design.
You mention using clamp() and calc(), I'll be looking these up as I haven't heard of clamp(), calc() I've used but not thought of using it for font sizes on mobile designs. Have you considered just using a media query to alter the design for mobile? It also appears that some of your margins are off. You can use the Figma file to see what these should be, if you highlight a section and then hold down alt (Win) or option (Mac) it will display margins and padding. If you have a Pro subscription try using the Dev tab to see the CSS if you get stuck.
Keep up the great work!
0 - @TheAashaySubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Turning the attribution into a box which inverts the color of background and text when hovered over, it might be unnecessary but doing something of my own idea feels good.
What challenges did you encounter, and how did you overcome them?Adapting to Git and GitHub's process to add, commit and push was initially challenging but now I'm comfortable with it.
@gmdpickettPosted 4 months agoYou've done well with the main challenge of laying out the main div with the qr code image using flexbox.
I would suggest looking at other solutions for the attribution content. While the inclusion of these as buttons shows some additional HTML / CSS skill, the content isn't meant to have this kind of focus on the page, it's more like the copyright in the footer.
Keep up the great work!
1
