Matthew
@gmatt20All comments
- @wiameHaKSubmitted 4 months ago
- @Tometoo0304Submitted 5 months ago@gmatt20Posted 5 months ago
Hello @Tometoo0304, thank you very much for sharing your project. I really like how it looks, it is looking extremely close to the design itself. Of course, there are differences such as the size in comparison with the design. A detail you missed on is bolding the location. Upon checking your HTML code, I like how you used buttons, I did not consider that! I used anchor so that when it is clicked, the user will be sent to another site. Consider this as well if you are planning to duplicate this work and style it into your own. It is awesome that you used span as well. Upon viewing your CSS code, it is very simple yet sophisticated. I really love your diversity in how you tackle this project. Really great work!
0 - @GAOV13Submitted 5 months ago@gmatt20Posted 5 months ago
Great job on it! I really love your eyeballing skills, it really shows. It seems you left out on bolding the "published" section like the "HTML..." section. There also needs to be a sort of double space in the description text. Try using line-height in CSS. Also, remove the margin-top of the "learning" or shorten it. Box shadow seems to have some opacity, whereas the final product does not, change that. Otherwise, nice work!
0 - @deva-prasad03Submitted 6 months ago@gmatt20Posted 5 months ago
It seems that you are overcomplicating the code. You are using too much divs. Although divs are best practices in larger scale websites, they can be too much for a smaller scale project like this. Limit it to only one div, which only contains the two <p> and one <img>. Generally, you are overcomplicating the CSS code as well. Make the code simpler and readable. You also forgot to implement the fonts. Other than that, the alignment looks great!
0