@alexberrios
Submitted
George Krause
@georgekrause
All comments
- George Krause• 90
@georgekrause
Posted
You will want to make sure you follow the style guild to get the colors for all the elements. Also want to make sure you don't use elements that are no longer supported. Overall it looks good just a few tweaks here and there. Lastly you'll want to write a good read-me. It will help you and other people who look at your projects. It also helps you learn new things as your do different projects.
0 - Zwelihlecomet2• 90
@Zwelihlecomet2
Submitted
What are you most proud of, and what would you do differently next time?
my fonts..iI am having difficulties in choosing the correct fonts for my texts
What challenges did you encounter, and how did you overcome them?
i had challenges when it came to fonts
What specific areas of your project would you like help with?
i would like help with fonts..which ones to use between rem and em?
George Krause• 90@georgekrause
Posted
Overall looks good. When choosing fonts always try to stay within the same font family ex. Arial and Helvetica. I seen you have a lot of extra space at the bottom between the links and the bottom of the card. To adjust that you can use max-height for your card, doing that will help you center your content.
0 What are you most proud of, and what would you do differently next time?
Wasn't too difficult so there's no strong proud feeling about this. I am happy I was able to recreate this as close as possible. Including paddings and margins using the figma files.
What challenges did you encounter, and how did you overcome them?
Can't think of any particular challanges I encountered.
What specific areas of your project would you like help with?
I still struggle with best practises and code organization, feel like I am writing too much code that would not be needed.
George Krause• 90@georgekrause
Posted
Overall your solution looks good. The thing i play around with is commenting out pieces of code that I'm not sure does anything to see what impact it makes. That should help you write less code.
0- George Krause• 90
@georgekrause
Posted
Good job. Looks good, I like how you got creative with the css part.
0
