@ivanorsolic95Submitted 4 months ago
gayathri-v1
@gayathri-v1All comments
- @gayathri-v1Posted 4 months ago
Hello there, Congratulations on completing this challenge!
This is amazing solution. I also have found the text "Last week" is not changing. I would suggest to use three functions, for daily, weekly, monthly and then you can add previousTimeSpan.innerHTML =
Last week - ${report.timeframes[timeframe].previous}hrs;previousTimeSpan.innerHTML =
Yesterday - ${report.timeframes[timeframe].previous}hrs;previousTimeSpan.innerHTML =
Last month- ${report.timeframes[timeframe].previous}hrs;In each function separately. You can check my code, I did the same. Although, I am not sure how efficient it would be I multiple function on same thing is used.
Marked as helpful0 - @manishsindurSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Used source Tag for pictures
What challenges did you encounter, and how did you overcome them?While using source tag we should always add a alternative img tag without it the picture won't visible.
What specific areas of your project would you like help with?What improvements i can make in my js?
- @thomashertogSubmitted over 2 years ago
- @rubensgabrielSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
What I'm most proud of is how I learned more about using grids within a project, I will definitely use them more
What challenges did you encounter, and how did you overcome them?The biggest challenge I encountered was how to let the page adapt to different screen sizes, I knew what it would look like on a cell phone and what it would look like on a desktop, but I needed to use my creativity to create a middle ground between these two things.
What specific areas of your project would you like help with?I believe that what I want to learn most would be how to use the grid even more
@gayathri-v1Posted 5 months agoHey there, For the quotation image in section-1, you can use background image property. I have used as below in css code, and I did not use"img" in html. background-image: url(/images/bg-pattern-quotation.svg); background-repeat: no-repeat; background-position: 80% 0%;
This is the only missing I have found in your solution. Overall its good. Keep coding!
Marked as helpful1 - @ayesoroboluSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of how well my responsiveness came out, even though it isn't perfect, it works very fine. I took more time on i, so i believe it looks more accurate.
What challenges did you encounter, and how did you overcome them?None really, i learnt some things from the last project that helped
What specific areas of your project would you like help with?None for now, but if there's somewhere you see there are issues. I'll be down for correction
- @coolprogrammerarpit007Submitted 6 months ago@gayathri-v1Posted 5 months ago
Hello, nice work!. I would suggest two things.
1)For rounded corners use "border-radius: 10px;" you can also use shorthand property and mention values for four corners.
2)use "background: url('image-mobile.jpg');" in media query for displaying different image for mobile and different for desktop.
keep learning. Cheers!
0 - @DomLevermentSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
This one was tough because it made you concentrate on styles within your html mark-up in lot more detailed way than previous challenges
What challenges did you encounter, and how did you overcome them?- ensuring styles same for markers
- media queries and mobile optimization
- aligning one of the into the centre, any suggestions i'd appreciate it!
- @ishika-santhaliaSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
Applying flex and centering the div.
What challenges did you encounter, and how did you overcome them?Center alignment of li tags
What specific areas of your project would you like help with?web responsive design, media queries
- @Andee-KSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I am most proud of getting the CSS almost the same as the preview. I would probably try to follow HTML/CSS semantics a bit better for next time since I am aware some of the elements probably do not follow the best CSS semantics.
What challenges did you encounter, and how did you overcome them?I had an issue with the author's profile picture not being within the div container I placed it in. I eventually just added a margin space at the top to lower the picture, but still am not sure if it was the best way fix it.
What specific areas of your project would you like help with?I would like to know if there are alternative ways to achieve the same styling results more efficiently. I feel as though my methods of styling are quite inefficient sometimes.
@gayathri-v1Posted 5 months agoThis is the most perfect to the preview! keep up the good work!
1 - @LuffySecSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
getting to complete this challenge, and i want to make the design looks more same next time
What challenges did you encounter, and how did you overcome them?none maybe
What specific areas of your project would you like help with?the design, its so hard to make it look same
@gayathri-v1Posted 5 months agoAmazing solution! I can also see you have added shadow for it, looks good. Keep coding. Cheers!
0
