@gabgonsan712
@BarrosLucasJavier
Submitted
What are you most proud of, and what would you do differently next time?
Nothing to add for the moment
What challenges did you encounter, and how did you overcome them?
Nothing to add for the moment
What specific areas of your project would you like help with?
Nothing to add for the moment
@gabgonsan712
Posted
Good proyect, I can see you use a mobile-first approach, it is good, everything is fine, only problem I found is that in the media querie it gets the mobile view when it is 1440px, so that is not right, you can establish a min-width, and max-width, so you can make a range for the view, so you can solve this.
What are you most proud of, and what would you do differently next time?
I used Pixelay extension for Figma this time, and it really helped me to see the difference between the design and my code. I'm always trying to make my html code pixel perfect.
I also used Flexbox and Grid to position the elements.
What challenges did you encounter, and how did you overcome them?
Using Pixelay helped me identify some mistakes I did when making the code.
What specific areas of your project would you like help with?
I still couldn't get the font the exact way as in design. Although I read figma instructions and I used font variable, it still slightly differs from the design (its weight, isusally). If someone can give me an advice on that, I'll very much appreciate that.
@gabgonsan712
Posted
Does the solution include semantic HTML? = Yes Is it accessible, and what improvements could be made? = The page is accesible, maybe you could add some transitions, or hovers on the table to make it more interactive. Does the layout look good on a range of screen sizes? =Yes mainly, but at the media querie for the width of 575px, the image stop adapting, and just stretch over the x axis. Is the code well-structured, readable, and reusable? = Yes it is structured and readable, but no really reusable, it could be more reusable if instead of using sass, uses scss, so can make mixins and variable, in my opinion will be better, and using flexbox could also avoid a lot of code and classes. Also with nesting in scss could avoid using a lot of classes. Does the solution differ considerably from the design? = No, very similar.
Marked as helpful
@AdityaDwiNugroho
Submitted
What are you most proud of, and what would you do differently next time?
centering a div
What specific areas of your project would you like help with?
Clean code and remove unused code
@gabgonsan712
Posted
Does the solution include semantic HTML? = Yes, just missing the landmarks
Is it accessible, and what improvements could be made? = I like it, very good design, it is accesible. Good use of sass
Does the layout look good on a range of screen sizes? = For most screens yes, for more little screens could use flex
Is the code well-structured, readable, and reusable? = Yes, the sintax with scss makes it easier to organize it
Does the solution differ considerably from the design? =No
@waliuakindolapo
Submitted
@gabgonsan712
Posted
I liked the design. You missed landmarks, the rest of the html semantic is good. You can use a normalize.css so you can delete the white margins in the page. It is not responsive on some screens. The solution is very similar to the design(very good) The page is accesible. In the css, instead of writing "font-family: Figtree;" for every item, you can use the tag * { font-family:Figtree;}, to save space, same case with the link for google fonts. For responsive, you can learn to use flex, as it is easy for responsive design.
Marked as helpful
@devchsykas
Submitted
@gabgonsan712
Posted
It uses correctly html, the page is accesible, the layout look good on a variety of screens, only in desktop I am not so convinced because it does not look as the requested one. The code is well structured, and the design is good, only using HTML fro structure and CSS for design
