somehow i manage to make it....any bugs or errors or mistakes please let me know
Folarin Akinloye
@folathecoderAll comments
- @log-baitSubmitted about 3 years ago@folathecoderPosted about 3 years ago
Hi Pal! π
Congrats on attempting another cool challenge. Kudos!!
There are some important features you forgot to implement:
1.) Drag and Drop functionality => A user should be able to re-arrange the list. 2.) localStorage => You did not store the current state of the app locally, this is why the inputs and theme settings clears when the app is refreshed. 3.) Theme Switch Implementation => You can easily make use of CSS to perform the theme switch by defining all the color variables under a class name and simply toggling the class on and off, instead of writing your code in JavaScript. 4.) The "TODO" logo can be implemented using letter-spacing in css. You don't need to literally space the text like you did on line 22 of your index.html => "T O D O"
Overall, good job! π Keep it up!
Marked as helpful1 - @folathecoderSubmitted about 3 years ago
Hi Devs! π
This is my first ever react application. I just started learning React 2 weeks ago and I must say, it has been fun ππ,kind! Thanks to my ES6 knowledge, the learning process was kinda fast.
In this Todo App challenge, I focused more on hooks for maintaining the state of the application and conditional rendering. It was not easy!
Note: The library I used to implement the drag and drop functionality really messed with the accessibility and markup performance. (React Beautiful DND Library)!!!
Kindly vet the way I use hooks and create components!
Thanks for your feedbacks! β€β€
@folathecoderPosted about 3 years agoNote: The library I used to implement the drag and drop functionality really messed with the accessibility and markup performance. (React Beautiful DND Library)!!!
0 - @zineb-BouSubmitted about 3 years ago
Hi everyone π thank you for checking out my solution. It's been like a month and half since I took this challenge, my first solution was using vanilla JS and Css, I learned more things since then so I decided to retake the challenge using different technologies. Any feedback is welcomed.
@folathecoderPosted about 3 years agoHey Great job!
Learn more about localStorage. With localStorage a user will be able to set a default theme instead of the theme switching back on reload.
1 - @ApplePieGiraffeSubmitted over 3 years ago
Hello, everybody! π
I finally completed another challenge! π I know it's been a while, but I'm happy to submit another solution after taking a little break. π
This was a short, simple challenge that I created with Svelte. Svelte is such a joy to use and it worked out really well with GSAP (which I used to add the animations to the site). I also used ScrollTrigger and smooth-scrollbar to enhance the animation and scrolling experience just a bit! π
And for a tiny surpriseβscroll past the hero section and back again to toggle the avatars of some of your favorite Frontend Mentors! π
Of course, feedback is welcome and appreciated! π Do let me know of any issues you find (since I'm afraid I'm bound to have missed something somewhere)! π
Oh, yes, and click on the giraffe for the attribution. π
Happy coding! π
@folathecoderPosted over 3 years agoHi APG!
I want to be like you when I grow up! π This is awesome and very sleek. Keep it up!2 - @raybags-web-devSubmitted over 3 years ago
I did not use the extact colors as the appear on the models instead i concentrated on the basic fucntionality and layout. I would love to hear from what you guys think. Feedback in important to me. Thanks.
@folathecoderPosted over 3 years agoHi Pal! I don't think the multiplication works. I tried it few times. Kindly check it out! Great work! π
2 - @kyle4realSubmitted over 3 years ago
How does it look? Question: I added the dropdown event listeners to the nav link divs, and even though the chevron elements are children of the nav link divs, when you click directly on them, the event doesn't trigger.. how do I fix this?
@folathecoderPosted over 3 years agoHi @kyle4real!
I think you really nailed most part of the implementation. Although, there are some small, but noticeable features you can adjust:
- The image assets you used for the mobile view are the desktop versions. In the images folder two different image designs were provided for each screen size. You can switch them using media queries.
- You forgot to make the footer menu "clickable links". Try wrapping them with an a tag.
- The SVG background in the "State of the Art Infrastructure" is not aligned properly on mobile. You might want to adjust this using media queries. Although, your implementations don't have to be pixel perfect, but features like that seem aesthetically important.
- If you try viewing the page on very large screen sizes like 5000px, you will notice that the page is not responsive. You can solve this by wrapping and centering the main content of the page.
- Also, whenever you submit your work, try clearing all the HTML and Accessibility errors on the page by clicking on "View Report".
Overall, you did a really cool job. I love the mobile menu drop-down and sleek finish.
Keep coding! π
1 - @albhattiSubmitted over 3 years ago
This is my first challenge submission on front end mentor.
I tried my best however, I would love to recieve feedback and review on my solution and also on how to make my code more simpler and shorter.
The only issue i faced was I cound not manage to apply the purple shade on the image. I tried googling but no success.
If the live site url does not work, please try https://frontendmentor01-nine.vercel.app/
- @albhattiSubmitted over 3 years ago
This is my first challenge submission on front end mentor.
I tried my best however, I would love to recieve feedback and review on my solution and also on how to make my code more simpler and shorter.
The only issue i faced was I cound not manage to apply the purple shade on the image. I tried googling but no success.
If the live site url does not work, please try https://frontendmentor01-nine.vercel.app/
@folathecoderPosted over 3 years agoHi Albhatti!
It is nice to see you tried out a challenge. Kudos! Your solution can be improved by making the card responsive across devices. Also, I found the image overlay tricky at first, but I eventually solved it.
You can checkout my solution on how I executed the overlay https://www.frontendmentor.io/solutions/responsive-card-component-using-scss-dPHJNYSk5
1 - @LesleyWesleySubmitted over 3 years ago
Hey guys! The only question I really have is about the "Learn More" link. I just have it as an anchor tag in my code, and I was wondering if that was okay, or if it would be better to give it a button tag? Thanks in advance for any feedback!
@folathecoderPosted over 3 years agoHi Lesley!
Based on this project, the use of "a" tag is appropriate since its only function is to link to an external or internal source.
There are other use cases where the button tag is appropriate. You can check out this article to learn more about buttons: https://css-tricks.com/use-button-element/
Have a great day!
Happy Coding! π1 - @Mardiya07Submitted over 3 years ago
Hey guysππ. I tried my first frontend mentor challenge with the 3 column card. Please take a look at it and give me feedback on what you think. What you think i could do to improve, omit or even better practices you think i should take up. I am open to all of them. Thanks in advance.
@folathecoderPosted over 3 years agoHi Mardiya! π
Nice attempt to create the sketch. Kudos! Your documentation and commit messages are lit. There are some changes you might wanna make.
I will start listing them under this thread:
- Meta description is important: Try to get in the habit of optimizing a page for SEO. SEO is one of the core skills of a frontend developer.
I recommend you checkout "SEO for developers" on YouTube (like a 20 minute video) and then learn about about open graphs. https://ahrefs.com/blog/open-graph-meta-tags/
- Remove the style tags in your html and it is considered a bad practice to write in-line css.
Writing styles inside your html will take precedence over external CSS, so overriding it will be very difficult.
And you will not be able to maintain your CSS code.
Always use external stylesheets!
- For button design, people usually use the "a" tag instead, because it gives you the flexibility of creating your preferred button from scratch. The "button" tag is a lot of work because you will need to override the existing style before creating yours!
Always use "a" tags for buttons!
- The way you name your CSS classes can be improved. I recommend you learn the BEM naming convention. You can check this on YouTube.
It will help you write nestable CSS. When you start using a preprocessor like scss or sass, you will appreciate it more!
-
Avoid using the break tag "br".... Except when necessary.
-
The 3 cards ought to be placed in the same container and not individually.
This is causing it to distort on smaller screen sizes..
For example, view your work on 1044px screen width!
You will notice that the cards are not properly aligned.LET'S MOVE INTO YOUR STYLESHEET!!π
- To avoid repetition, always add general settings to the body of your website and not the "main"
Stuffs like font family, background color, etc should be added to the body.
-
You are good with flexbox π
-
You can learn more about using variables to write more maintainable css. With this method, you will just need to assign variables to resuseable properties and then insert them when needed.
You won't need to keep repeating yourself.
Below is a good code along video by KEVIN POWELL, it helped me get comfortable with css.
https://youtu.be/bn-DQCifeQQ
Overall, it is a good start! Keep coding! π
3 - @erickcernaSubmitted over 3 years ago
Hi everyone, I did this project to practice my CSS Grid and FlexBox knowledge. I would appreciate if you leave me any comments or suggestions about this project.
@folathecoderPosted over 3 years agoHi Erick!
Nice submission! Kudos! Your implementation looks nice and it responds well on all devices.
There are some tiny details you missed:
-
You used the wrong font family for your card headings. It ought to be "Big Shoulders Display".
-
The buttons are a bit bigger than the sketch, you can solve this by reducing the left-right padding to 30px or so, instead of 50px. As a Frontend Developer, you should always try to recreate a sketch design as it is. (Attention to details!)
-
You can work on accessibility by using rem instead of pixels.
-
You can also assign variables to your font family, just like you did for colors. This will make your work more maintainable and avoid repetition.
-
You can take full advantage of SCSS functionalities by using mixins for your media queries (if you want to!).
Overall, you have done well. Keep it up, Pal!
3 -
- @almoratallaSubmitted over 3 years ago
Hello everyone, I am open to suggestions or any forms of feedbacks to improve my skills. Please feel free to share if there any points that I can improve or tips for best practices that I can follow. Any form of remarks will be highly appreciated. Thank you!
@folathecoderPosted over 3 years agoHi Alain!
Your page is giving an "Error 503 Service Unavailable" prompt. Kindly fix it!
2