Saulius Gražys• 210
@sgrazys
Submitted
I would be grateful for any comments or observations :)
Engr. Fisayo Michael Animashaun (MNSE, FMP®, COREN)
@fmanimashaun
All comments
@fmanimashaun
Posted
Nice work @sgrazys
0- elishabhatti• 380
@elishabhatti
Submitted
@fmanimashaun
Posted
nice implementation @elishabhatti
0 - iamporrrrrrrrr• 190
@iamporrrrrrrrr
Submitted
What are you most proud of, and what would you do differently next time?
None
What challenges did you encounter, and how did you overcome them?
None
What specific areas of your project would you like help with?
None
@fmanimashaun
Posted
Nice implementation @iamporrrrrrrrr
0 @fmanimashaun
Posted
nice work @Hyuuga81
0- Keshava Banda• 10
@keshavaBanda
Submitted
What are you most proud of, and what would you do differently next time?
This time I learned more with this project. hope I feel prod to do the UI work atleast perfect alignment, and colors.
What challenges did you encounter, and how did you overcome them?
NO
What specific areas of your project would you like help with?
All the project area
@fmanimashaun
Posted
Nice work @keshavaBanda
0 - ga6169073• 70
@ga6169073
Submitted
What are you most proud of, and what would you do differently next time?
I made this without Figma file
What challenges did you encounter, and how did you overcome them?
Some font weight not accurate
What specific areas of your project would you like help with?
Reponsive and some detail
@fmanimashaun
Posted
@@ga6169073 perfectly done! well done
0 - KauaGabriell• 60
@KauaGabriell
Submitted
@fmanimashaun
Posted
Good job so far @@KauaGabriell, You generally got the overall card layout, however, I think you miss the color code for the background and I think the path to your image is missing.
Marked as helpful
0 - zaza mirotadze• 270
@zazamirotadze
Submitted
@fmanimashaun
Posted
Hi @zazamirotadze,
Nice work! But I think the final design might need a little vertical spacing. I am quite impressed with the use of bootstrap for the challenge, ingenious!
I noticed you used a lot of div instead of semantic HTML tags. I think the use of figure tag card component and figcaption tag for the card details and info would have been better tags instead of divs
Also, I noticed the card box-shadow was not implemented.
0 - André• 40
@zeppelisama
Submitted
I made some improvements. This time i spent a lot of time cleaning up my code and organized every section as much as i could. Please let me know if there is something messy or wrong. Tips concerning techniques, methods or whatever are also welcome :)
Att, André Vinícius.
@fmanimashaun
Posted
Hi @@zeppelisama,
Nice implementation! However, I feel you might need a better file structure for better file management. e.g saving all your styling in a CSS folder and all images in a img folder or something like that.
On the code, I see you are trying to use the transform property to centre the card on the page, but I think using flexbox will do a better job.
Marked as helpful
1 - dralveol• 160
@dralveol
Submitted
Why do we have so much hero image types ? Is the nav choice semantically appropriate ? At first i went for section but section needs a heading so i went for nav since it references diverse options of the skilled learning page.
@fmanimashaun
Posted
Hi @@dralveol,
Nice implementation. You can ignore the provided image in the downloaded project starter folder and extract all your assets from the provided Figma file. I think it will be a nice way to get familiar with asset extraction from design.
The answer to your question about using a nav tag in the service section of the page is yes. nav tag is basically to style page navigation with respect to the semantic structuring of a page.
Thus, a section or div might have sufficed to structure the section. I practically use a section tag for that section of the page since I consider the first card of the section to be the title of the whole section.
0 @Vvnyy
Submitted
Hi! I had a problem and I didn't understand what was causing the error in the <button> (HTML lines: 52 to 55; CSS lines: 94 to 115) that was cut in half at the end of the card in mobile mode. Also, any wrong syntax or that could be done differently but still simple that you can point out will be of great help to recognize where I can still improve.
@fmanimashaun
Posted
Hi @@Vvnyy,
Great attempt! I noticed you were using fixed height in your code: for example, in lines 29, 38, 97, 122 and 131 in your CSS file. Kindly remove all fixed heights. If you set the right font size, padding and margin of all elements, you will get the right height without specifying them directly. The best practice is to let the content of your box or container determine its height and width, except when you need to set values like max-width/min-width to restrict your content from growing/shrinking out of proportion.
I hope this help! happy coding
2- Gaurav Singh• 440
@Gaurav4604
Submitted
Hi everyone! I've implemented this challenge using Flexbox, Is it viable to use Grid for the same?
What parts of my styling can be improved upon?
@fmanimashaun
Posted
Nice work @Gaurav4604!
Using a grid will be overkill, as flexbox will do just right for the implementation. Generally speaking, a grid will be more suited for an overall page layout than trying to align elements in a component like a card example.
Overall, you did a nice job with your implementation.
Marked as helpful
0
