@codeyeskrishSubmitted 8 months ago
Mohamed Ahmed
@fienmsaAll comments
- @fienmsaPosted 8 months ago
Hello @codeyeskrish!
Your solution looks great!
I have a suggestion for improvement:
Use <main> to wrap the main content instead of <div>. Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.
š This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - @JakeJames00223Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
none
What challenges did you encounter, and how did you overcome them?none
What specific areas of your project would you like help with?none
@fienmsaPosted 8 months agoHello @JakeJames00223!
Your solution looks great!
I have a suggestion for improvement:
Use <main> to wrap the main content instead of <div>. Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.
š This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - @DanielClement37Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of the fact at how simple it turned out being. Next time I now know how to center divs better.
What challenges did you encounter, and how did you overcome them?Getting the component centered vertically ended up being the biggest challenge for me. Figured out that I could make the body element display flex and that solved it for me instantly
What specific areas of your project would you like help with?I felt like I was guessing the widths and padding elements trying to eyeball compare to the image. Also I never know which sizing units I should use and when I should use them.
@fienmsaPosted 8 months agoIam also beginner and centering element can be difficult specialy when you're beginner, i do like to use grid if its only centering element and it takes only two lines of code to do that, im glad you did it and solved your own problems, it's all about solving a problems.
0
