Skip to content
OverviewSolutions
22
Comments
29
Fallou Jeng
@falloumacbook

All comments

  • Fallou Jeng•540
    @falloumacbookPosted 3 months ago

    Hi @Kelvin Ariedi, congratulation on completing this challenge. However, i have few suggestion regarding the view on mobile screens. The deskop design is cool but on smaller devices the container is so thin and the words are breaking out of the container. I tried looking at your codebase, but i didn't find your repository.

    1
  • Fallou Jeng•540
    @falloumacbookPosted 3 months ago

    Nice work @Nova and the responsiveness on mobile screens is also good. The toggling sound is really cool.

    1
  • Fallou Jeng•540
    @falloumacbookPosted 3 months ago

    Hi @Alma congratulation once again for completing this challenge. I've noticed that you are not using the favicon image on your solution. It is a good practice to add it in your work. However, in this case you can add it just below the link of your style.css using the code below.

    <link 
    	rel="icon"
	type="image/png"
	sizes="32x32"
	href="images/images/favicon-32x32.png"

    />

    happy coding my dear.💻

    0
  • Fallou Jeng•540
    @falloumacbookPosted 4 months ago

    @Alma nice work. The responsiveness on mobile screens are also good. Keep up the good work. Happy Coding.....💻

    Marked as helpful
    1
  • Fallou Jeng•540
    @falloumacbookPosted 4 months ago

    Nice work @Ahmed the responsiveness for mobile devices is also good. Keep up the good work.

    1
  • Fallou Jeng•540
    @falloumacbookPosted 4 months ago

    Hi Alma, congratulation on completing another challenge. we cannot view your source code i think you missing the repository URL. You only upload the live site URL.

    Marked as helpful
    1
  • Mazen Hassan•600
    @Mazz100Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I am really grateful that I kept going till the end, even though I got stuck for an extended period and took longer than expected to finish the challenge but I finally did it.

    I received a lot of help along the way, and I went through many rounds of refactoring and cleaning up messy code. Despite the time it took, it was a great learning experience.

    What challenges did you encounter, and how did you overcome them?

    I faced difficulty with the approach of mapping list and passing props with unique key and as result I had all the code separate and meaningless, to overcome it I mapped the product data directly into `` as the child allowing for easy prop passing, then created 3 functions in App.jsx to handle all cart updates.

    What specific areas of your project would you like help with?

    I am open for any feedback offered, I already asked for enough help from community and I just need to get a better idea on how React works and read docs more often. Thanks for taking a look at my solution :)

    Product list with cart using React | Tailwind

    1
    Fallou Jeng•540
    @falloumacbookPosted 4 months ago

    Nice work as always man, it would be great if you move the cards a little bit left.

    1
  • Fallou Jeng•540
    @falloumacbookPosted 12 months ago

    Hi dear, congratulation on completing this challenge. I've check solution and I love it. However, I have one suggestion regarding your background positioning. You can use the code below to make your background look as close as the design given.

    body{

    background-image: url(images/bg-pattern-top.svg), url(images/bg- pattern-bottom.svg);

    background-repeat: no-repeat;

    background-position:

    right 50vw bottom 40vh,

    left 50vw top 40vh; }

    Marked as helpful
    1
  • Fallou Jeng•540
    @falloumacbookPosted 12 months ago

    Hi mate, congratulation on completing this challenge, i have one suggestion regarding your solution. You can use the code below to center your work without using margins.

    body { margin:0; display: flex; justify-content :center; align-items: center; min-height:100vh; }

    Hope you find it helpful. Happy coding mate! 🙌

    Marked as helpful
    1
  • Fallou Jeng•540
    @falloumacbookPosted about 1 year ago
    This comment was deleted 4 months ago
    1
  • Fallou Jeng•540
    @falloumacbookPosted about 1 year ago

    Hi bro, congratulation on completing this challenge! I have one suggestion regarding your background. The background has a pattern.

    body {

    background-image: url(images/pattern-background-desktop.svg);

    background-repeat: no-repeat;

    background-color: hsl(225, 100%, 94%);

    background-size: 100%;

    }

    happy coding mate!!!

    Marked as helpful
    3
  • Fallou Jeng•540
    @falloumacbookPosted about 1 year ago
    This comment was deleted 4 months ago
    1