gio
@fakegioAll comments
- @pavocadosSubmitted about 2 months ago@fakegioPosted about 2 months ago
The page is responsive, the html is well-structured, and even the file system is neat and organized. I would just work on the spacing between elements and letter spacing in the perfume category.
1 - @beqqiSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I am not a pro user so I was not able to get the design files like the challenges before so it I don't know accurate it is, but I have tried my best to make it similar.
What challenges did you encounter, and how did you overcome them?I was not able to get the media-query to work so this implementation is only for desktop, hopefully I will get it right after learning responsive designs on my coming paths.
What specific areas of your project would you like help with?I got better at my layout, but I was still having troubles with accessing specific elements and space them as I would like to.
@fakegioPosted about 2 months agoNot bad. I'd suggest making the title font size bigger, changing the subheading colors to a brown color, and instead of using a .bold class, you can use the <strong></strong> element. Otherwise, good job!
0 - @Black-crypto-gifSubmitted 2 months ago@fakegioPosted 2 months ago
Looks good. I like how organized the css is, especially with the variables. I would point out that some classes aren't used and instead are targeted via element (ex: img for social-avatar and a for social-link). Other than that, great work.
Marked as helpful1 - @mariokreitzSubmitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
media query. i always used mobile first, but this time i did it the other way around :D
@fakegioPosted 3 months agoThis solution is responsive, fluid and closely resembles the design. I like how the classes are descriptively named, indicating the color and font/font weight of an element. To improve, I'd recommend using more semantic elements and less div elements, this would resolve some accessibility issues, and refrain from using the important property. Other than that, looks good 😁
Marked as helpful1 - @NaeemSlayerSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm most proud of achieving a pixel-perfect match to the design and using semantic HTML effectively. Next time, I would spend more time on optimizing the responsiveness.
What challenges did you encounter, and how did you overcome them?One challenge I encountered was ensuring cross-browser compatibility, which I overcame by thorough testing and using CSS resets.
What specific areas of your project would you like help with?I would appreciate feedback on improving the responsiveness of my layout, particularly in handling various screen sizes and orientations.
@fakegioPosted 3 months agoThe conciseness and attention to detail looks good. The HTML structure is well-structured and readable. I would recommend using the figma designs as they make development a lot quicker.
Marked as helpful1