Skip to content
OverviewSolutions
3
Comments
2
Alex Blue
@fake-alex-blue

All comments

  • Alex Blue•70
    @fake-alex-bluePosted 8 months ago

    A nice solution here, it looks good, and your code is well structured and easy to read. I like that you used flexbox here, although you might want to look a little closer at your implementation, on my screen the large image appears centered but doesn't fill enough of the width.

    I'd probably also have liked to see more semantic HTML used; but ultimately the challenge is to create a card component, outside the context of a larger site where it might be used; so I don't think that's too critical.

    The main point I would mention is to do with the border-radius attributes on both the card itself and the yellow, card image. What you've gone for doesn't quite match the design file - and I'm not sure I prefer your version to what the design suggests.

    The card is probably looking for a border-radius: 20px and, from memory, the large title image is looking for a border-radius: 10px - but I think you'll also need to create a more specific CSS selector so that you can target the larger title image without also catching the author photo.

    Marked as helpful
    0
  • Daniel Wiśniewski•30
    @TheWichaSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I don't know tbh :) Maybe i would use tailwind CSS

    What challenges did you encounter, and how did you overcome them?

    only with Figma, but i finally found out what fonts are there

    What specific areas of your project would you like help with?

    in this project i dont know :)

    qr-code

    2
    Alex Blue•70
    @fake-alex-bluePosted 8 months ago

    I like the approach you took to this solution. It's clear you've made some different stylistic choices, using Montserrat for the h2 text, for example - which I can't argue with personally; I think it looks good.

    The only small thing I'd mention, is that you've not added the box-shadow on the card, which is a shame; I reckon it elevates the design of the original; although to be honest it's so subtle that I completely missed it on my first attempt at the challenge.

    Marked as helpful
    0