All comments

• 

  thetika•40

  @josuethetikaSubmitted over 1 year ago

  i hope i will improve my self with your feedback

  

  QR6-code-component

  4

  80
  

  EvtimEvtimov•30

  @evtimov-ptrPosted over 1 year ago

  First of all congratulations on completing this challenge. Now to what you could improve

  1. I see that in the HTML you have used the <br> tag few times. It is really a good practice to avoid using <br>. Instead what you can do is to use either <div>, <span> or <p> tag. In this challenge it's not a big deal, however in the future, please try to get used to the other tags.
  2. The alt property in the img is empty. It is always a good idea to check your structure from time to time just so you can avoid such mistakes.
  3. The card itself appears to not be aligned properly, and the problem is that you are setting margin-left and top on the img with different values, what you could do is to just simply shorthand this. if you say margin: 5px for instance. Using this it will apply the 5px on each side instead of manually declaring it with different values, that will completely mess with the alignment of the element.

  That was from me in terms of what you could improve. Good luck and happy coding 🙂

  Marked as helpful

  0