Skip to content
OverviewSolutions
4
Comments
9
Paminos
@epalpam

All comments

  • Paminos•230
    @epalpamPosted about 3 years ago

    @Stygan,

    great job with Flexbox!! keep up coding!

    Just one minor comment from my side is to try to use semantic HTML, so for example instead of div's you could use tags like section, header, footer etc etc

    Marked as helpful
    1
  • Paminos•230
    @epalpamPosted about 3 years ago

    @0x41-li,

    great job with Flexbox!! keep up coding great projects!

    Some minor comments from my side:

    • for fontawesome fonts, try to use a CDN instead of copying the whole folder to each and every project

    • try to use semantic html as much as possible, e.g instead of div you could use section or aside tags

    Marked as helpful
    0
  • Paminos•230
    @epalpamPosted about 3 years ago

    @EyadOmar,

    great job with CSS Grid & Flexbox, keep up coding great projects!!

    Some comments from my side:

    • it would be helpful to include a README file in your github repo

    • in the mobile version, try to make the top padding of each item (item-1, item-2, item-3) smaller

    • for 'Learn more' functionality, you could use an 'anchor tag' instead of a button

    Marked as helpful
    0
  • Paminos•230
    @epalpamPosted about 3 years ago

    @Brobit

    good job done!! congrats

    Some comments from my side:

    • try to use semantic html, eg. instead of div use tags like section, main, header etc ect

    • your css code is not so easy to follow, try to make it more readable !

    Marked as helpful
    1
  • Paminos•230
    @epalpamPosted about 3 years ago

    @bhornbhaya great job!! keep it up like this!!

    Some minor comments from my side:

    • try to use semantic html, e.g instead of div use main or section or aside etc...

    • your css is a little hard to follow, which method do you follow? Is it a mobile first approach that is recommended by the community?

    Again, great job!

    Marked as helpful
    0
  • Paminos•230
    @epalpamPosted about 3 years ago

    Hi @nnaydenow,

    I cannot view your code, I get a page not found error...

    0
  • Paminos•230
    @epalpamPosted about 3 years ago

    Hi Muhammad, great project, keep up the good work!!

    Some minor comments from my side:

    • try to use a README file with your github folder, it makes repo look much more professional

    • try to follow the 'mobile first' approach, meaning make first the mobile version of the design and then the tablet and desktop ones. There are a lot of pros with that approach, you can also google it.

    Hope that helps

    Marked as helpful
    1
  • Paminos•230
    @epalpamPosted about 3 years ago

    Great job! Keep up coding projects!!!

    Some comments from my side:

    • try to make use of semantic html, e.g instead of div use tags like section, main, aside etc...

    • try to make css more efficient, there is so much css code for such a small project

    but.... you are on a great start congrats!!

    Marked as helpful
    1
  • Paminos•230
    @epalpamPosted about 3 years ago

    Great job!! Keep up by coding more websites!

    Related to your first question, I would suggest:

    margin: auto; width: 90% or 90vw; to your container.

    So you will have a container horizontally aligned to 90% of the viewport and also responsive.

    Hope that helps.

    Marked as helpful
    1