All comments

• 

  Devn777•10

  @Devn777Submitted 9 months ago

  Are there any bad practices I need to watch out for?

  

  QR Code with HTML & CSS

  2

  60
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey @Devn777. I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand.

  For example, everything from your <div.card> to <span.smalltext> could be wrapped in a <main> tag, while the <div.attribute> could be replaced with a <footer> tag.

  You also didn't add the border-radius property to your QR image.

  Lastly, you should get rid of the style tag contained in the head tag since you've already created a file containing your styles

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  1
• 

  Ogechi Juliet Uhegbu•40

  @oge-devSubmitted 9 months ago

  I need a review, and any feedback would be highly appreciated.

  

  Social links profile using Semantic HTML5,CSS custom properties

  3

  40
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey @julietoge,

  Your solution is commendable, even excellent.

  In the event that you do not possess the Figma design files, I would like to suggest utilizing a browser extension named Perfect Pixel.

  This extension enables you to conduct precise comparisons between your completed project and the design images provided upon downloading the project, facilitating accurate dimension verification. Its functionality can prove invaluable in your future projects.

  I hope you found this helpful

  Keep up the excellent work!

  Marked as helpful

  0

  This comment has received 2 repliesShow
• 

  KTDKasp•20

  @KTDKaspSubmitted 9 months ago

  

  Social links solution

  2

  20
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Dear KTDKasp,

  I have reviewed your solution and find it commendable, even excellent.

  In the event that you do not possess the Figma design files, I would like to suggest utilizing a browser extension named Perfect Pixel.

  This extension enables you to conduct precise comparisons between your completed project and the design images provided upon downloading the project, facilitating accurate dimension verification. Its functionality can prove invaluable in your future projects.

  Hope you found this helpful

  Keep up the excellent work!

  1

  This comment has received 1 replyShow
• 

  Ghosk04•30

  @Ghosk04Submitted 9 months ago

  The most difficult for me was to position items on the website, cause my items were not align like they would be. I'm perfectly of what i wrote in my code. I just want to know if is it a way to do this challenge easier than mine. Thank you!

  

  Qr code component

  2

  50
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey Ghosk04. I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.main> could be replaced with a <main> tag, while the <div.attribute> could be replaced with a <footer> tag.

  Also, to position your "<div.big-box>," I would suggest:

  height: 100vh; justify-content: center; align-items: center; max-width: 375px (the recommended width by the design)

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  azgpapi•90

  @azgpapiSubmitted 9 months ago

  This is a challenge by FrontEnd Mentor to test our coding skills, and a perfect project made by using css Flexbox.

  

  QR code component made with css Flexbox

  3

  41
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey azgpapi. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.container> could be replaced with a <main> tag while the <div.box> could be replaced with a <footer> tag.

  I also noticed an issue with image linking, as your image doesn't seem to load correctly. Ensure that you are using the correct file paths or URLs.

  I'd also like to offer a gentle reminder to consider following style guidelines more closely.

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  0

  This comment has received 1 replyShow
• 

  nanishipi•40

  @nanishipiSubmitted 9 months ago

  

  Responsive QR code Card

  2

  50
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey nanishipi. I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.container> could be replaced with a <main> tag, while the <div.attribute> could be replaced with a <footer> tag.

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Abhishek Kumar Pandit•40

  @Abhishek-0899Submitted 9 months ago

  

  Qr Code Component

  1

  20
  

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey Abhishek, nice work! I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.container> could be replaced with a <main> tag while the <div.attribute> could be replaced with a <footer> tag.

  I also noticed an issue with image linking, as your image doesn't seem to load correctly. Ensure that you are using the correct file paths or URLs.

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  0