Skip to content
OverviewSolutions
2
Comments
3
Emanuele
@emazack

All comments

  • Emanuele•40
    @emazackPosted about 2 years ago

    Hi! It looks very similar to the figma, great job!

    Just a couple of things:

    1. Give a look to the report and try to solve the issues https://www.frontendmentor.io/solutions/qr-code-component-q-l7JrPWzY/report

    2. Do not use <br> you have no control on it. Try to use max-width, or width for the box that contain the text and use the very same line-height and font-size, in this way you re pretty sure that you have the same apparence

    Bye! :)

    0
  • Emanuele•40
    @emazackPosted about 2 years ago

    Hi! Your result is very similar to the figma, very nice. Just have this advice for you:

    1. You have some accessibility issue, try to look at them https://www.frontendmentor.io/solutions/qr-code-component-done-with-html-and-css-7nUKVZpINy/report
    2. I saw that you used style in line, try to avoid it, always make style in the stylesheet
    3. Never use !important; If you use important, there is something that is not going as you would

    have a nice day!

    0
  • Nien•170
    @trandainienSubmitted about 2 years ago

    All comments are welcomeeee ╰(°▽°)╯

    QR Code Component

    1
    Emanuele•40
    @emazackPosted about 2 years ago

    Hi. Very nice! I liked that you used variables for the colors and you made a good exercise for semantic HTML.

    Care to the detail:

    1. The color of the h1 title is not black
    2. The vertical distances are not precise, the component seems to be shorter than the normal. Too different space among the texts

    Bye! :)

    Marked as helpful
    0