강서현• 10
@vdnuit
Submitted
Emanuele
@emazack
All comments
- Emanuele• 40
@emazack
Posted
Hi! It looks very similar to the figma, great job!
Just a couple of things:
-
Give a look to the report and try to solve the issues https://www.frontendmentor.io/solutions/qr-code-component-q-l7JrPWzY/report
-
Do not use <br> you have no control on it. Try to use max-width, or width for the box that contain the text and use the very same line-height and font-size, in this way you re pretty sure that you have the same apparence
Bye! :)
0 -
@MissCryptoSarcasm
Submitted
Emanuele• 40@emazack
Posted
Hi! Your result is very similar to the figma, very nice. Just have this advice for you:
- You have some accessibility issue, try to look at them https://www.frontendmentor.io/solutions/qr-code-component-done-with-html-and-css-7nUKVZpINy/report
- I saw that you used style in line, try to avoid it, always make style in the stylesheet
- Never use !important; If you use important, there is something that is not going as you would
have a nice day!
0- Nien• 170
@trandainien
Submitted
All comments are welcomeeee ╰(°▽°)╯
Emanuele• 40@emazack
Posted
Hi. Very nice! I liked that you used variables for the colors and you made a good exercise for semantic HTML.
Care to the detail:
- The color of the h1 title is not black
- The vertical distances are not precise, the component seems to be shorter than the normal. Too different space among the texts
Bye! :)
Marked as helpful
0
