All comments

• 

  Nurcholis• 420

  @cholis04

  Submitted over 2 years ago

  I'm trying to create a menu on this landing page using CSS without Javascript. Of course, there are limitations in manipulating elements.

  

  Responsive Menu using Checkbox without JS | Loopstudios Landing Page

  2

  340

  

  Emad Jaber• 130

  @emad2411

  Posted over 2 years ago

  Great solution

  as I can see you have two accessibility issues.

  • your footer should be contained in a <footer> tag
  • your main content should be contained in a <main> tag

  other than that I can see everything is perfect , great coding.

  1

  This comment has received 1 replyShow
• 

  Jason Arrington• 10

  @jearrington

  Submitted almost 3 years ago

  I would really appreciate any feedback. What I could have done better? Whatever you can teach me I would love to learn. Thank you so much! 👍

  

  Order Summary Component Responsive Webpage using Flexbox

  1

  41

  

  Emad Jaber• 130

  @emad2411

  Posted almost 3 years ago

  hi Jason,

  good work , there are few comment which will improve your code:

  • as you can see you have an Accessibility issues like you are using h5 instead of h1 since heading can be increased by one only .
  • wrap your html code with main and footer.
  • you can use css variables for colors : :root { --pale-blue: hsl(225, 100%, 94%); --bright-blue: hsl(245, 75%, 52%); --very-pale-blue: hsl(225, 100%, 98%); --desaturated-blue: hsl(224, 23%, 55%); --dark-blue: hsl(223, 47%, 23%); }
  • pay attention to your margins for the cancel order link
  • add transitions to your interactive links so when you hove on them you have a smooth transition between colors.

  I hope my comments are useful

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Alexandre• 80

  @alexandre-dev29

  Submitted almost 3 years ago

  

  Order Summary Card Using FlexBox

  1

  10

  

  Emad Jaber• 130

  @emad2411

  Posted almost 3 years ago

  hello Alexandre,

  good work here are some comments:

  • change the background-color of the .card_plan to --very-pale-blue
  • decrease the top and bottom padding in the .card_plan to match the original design
  • i think also you need to increase the btn margin-top.
  • you didn't put a hover effect on change link and cancel order link.

  I hop above comment helps to improve your layout

  0

  This comment has received 2 repliesShow
• 

  Marcelo• 80

  @marcelo-jrs

  Submitted almost 3 years ago

  I had some issues doing the background of the mobile design, if someone could help me i would be glad

  

  CSS, HTML and Flexbox

  2

  20

  

  Emad Jaber• 130

  @emad2411

  Posted almost 3 years ago

  Hi Marcelo,

  I learned how to do the background by reading about the CSS background-position Property. its really useful in such cases .

  Please view the given report in your solution page since it seems you have some issues in the ACCESSIBILITY and your HTML

  Marked as helpful

  0