The booking menus was very involved with a lot of custom styling. I would be interested if anyone has any insights on a better way to structure it. Thanks.
Elroy Toscano
@elroytoscanoAll comments
- @brodiewebdtSubmitted over 2 years ago@elroytoscanoPosted over 2 years ago
The website is well designed/developed.
Here are some pointers you could look into:
- Give a shot at SCSS and have a look into BEM as it'll help you out with segregating styles effectively.
- At the booking page, there is a little empty gap associated with the styling at the bottom of the page.
Marked as helpful0 - @aleksFedotovSubmitted over 2 years ago
First time using Middleware in Redux Toolkit to store and load data from local storafe. Feedback will be highly appreciated
@elroytoscanoPosted over 2 years agoWell done! The animations really add to the overall experience of the app
Marked as helpful1 - @anoshaahmedSubmitted almost 3 years ago
I used desktop-first approach for this, and now I know for sure that mobile-first approach is best.
Please let me know what I can do to improve.
@elroytoscanoPosted almost 3 years agoHi Anosha, you've done a brilliant job at this. Not only is the design pixel perfect but also semantically correct. You've even gone a step further and designed the github readme, so well done 👍
One tip: Consider placing your
img
elements in afigure
element as thefigure
element represents self-contained content, whereasimg
is just embedding an image.Hope this helps. Cheers.
Marked as helpful1 - @DrunkenNeoguriSubmitted almost 3 years ago
(I wrote this using Google Translate. Please forgive the grammar.)
Hello! I did this project as the 6th challenge. :D
The image I saw in the design folder in the starter file did not have an image of the change in hover state, so I thought about how to make the sign up block look like a button.
And, I saw a box-shadow in the image, so I put it in to solve it!
Thank you for watching and if you have any other advice, please feel free to reply me! XD
@elroytoscanoPosted almost 3 years agoBrilliantly done, the design is responsive as well. You may improve the visual feedback by providing
cursor:pointer
and changing the color of the button when hovering over the button.Hope this helps.
Marked as helpful1 - @dzoni19Submitted almost 3 years ago
Where is the error question now? :/
@elroytoscanoPosted almost 3 years agoBrilliantly done Nikola, the design is pixel perfect 👍.
The accessibility issue can be resolved by using an
aria-label:"change theme"
on the button withtodo-icon
class. You may provide a little more horizontal padding for each todo list item as thecircle
andcross
icon are close to the edge of the list item box.Marked as helpful1 - @darryncodesSubmitted almost 3 years ago
Hi everyone 👋
Good to be back after having a few weeks off over the holidays.
I used this challenge to learn more about accessibility, focusing on:
- semantic mark up and use of interactive elements
- custom focus states
- use of aria-label
- making sure i removed animations and transitions for people that prefer not to see them
I also had a play around with some animations which was great practice!
Any feedback that could help me to improve my understanding of accessibility would be very welcome!
Happy coding 🤙
@elroytoscanoPosted almost 3 years agoBrilliantly done Darryn, especially the use of the
meter
tag. The code is very readable as well. Great job 👍1 - @anoshaahmedSubmitted almost 3 years ago
First time using SCSS! I love it! It's so convenient!
One thing I wish I had done differently is not nesting. I don't know why I was nesting at first... maybe because I was using SCSS for the first time?and it felt cool? But when it came to do media queries, it was so inconvenient to deal with specification etc. I'm gonna make sure not to do that again if I don't need to.
One problem I kept having, with this solution, was that every time I would save, and my live server would reload, the font-size of random paragraphs would appear larger than before I saved last time. And it was weird because I didn't even touch the font-size of those paragraphs. So, I would stop the live-server and open it again, and the font-size would be back to normal. Then I'd save again, and the font-size would appear larger. Ugh, it was such a hassle.
But yay I'm happy with the result!
@elroytoscanoPosted almost 3 years agoHi Anosha, you've done a great job at the design. Pixel Perfect. The animations are really smooth 👍
There's just one issue, the
buttons
are designed witha
(link) as the element, which is semantically incorrect as when you click on any of thebuttons
, notice theurl
changes tohttps://anoshaahmed.github.io/fem12-clipboard-landing-page/#
. The "#" symbol at the end represents thehref
of thelink
element which directs you to another page instead of abutton
. Here's an article to help you out with the differentiation between these elements: Difference between link and button.Hope this helps.
Marked as helpful1 - @soewaiyanagSubmitted almost 3 years ago
This is the hardest challenge I have ever done on this website. I learned not only design but also how to deal with nested objects from this challenge. I'd love it if I get feedback so that I can improve. Thanks to frontendmentor.io for creating this challenge.
@elroytoscanoPosted almost 3 years agoYou've done a great job with the design and functionality. You can reply, you can add only one like/dislike, however, when you click on the delete button, there needs to be a "pop up", which is a warning to the user regarding deleting the comment. Again, the design is well done, good job 👍.
Marked as helpful1 - @NerijusNoreikaSubmitted almost 3 years ago
Made with Vue along with Grid and Flexbox and SCSS.
Most annoying part was the range styling.
Feedback is always appreciated! ;)
@elroytoscanoPosted almost 3 years agoWell done. Pixel perfect design. Whenever you use form elements, use a label tag as it facilitates accessibility.
Download AXE dev tools so that you can clear any accessibility issues while coding : https://www.deque.com/axe/devtools/
1 - @skyv26Submitted 10 months ago
I will appreciate any feedback. Please check my work and leave your feedback.
@elroytoscanoPosted almost 3 years agoHi Aakash, good job with the design. There's just a little box shadow missing on Kira and Jeanette's cards.
Seeing through your code, you've used
p
tags for each article's title/persona name, instead, swap them forh2
tags to improve the semantic correctness as even each article/section needs a heading tag.Download AXE dev tools so that you can clear any accessibility issues while coding : https://www.deque.com/axe/devtools/
Hope this helps.
Marked as helpful1 - @hg8116Submitted almost 3 years ago
First intermediate project submission on Frontend Mentor. Any and all suggestions are greatly appreciated.
@elroytoscanoPosted almost 3 years agoThe design is pixel perfect and the functionality is on point. Great job.
You could improve the visual feedback by having
cursor:pointer
on interactive elements like buttons and the theme switcher.Your accessibility warning can be taken care of by wrapping the "calc" text in a
h1
instead of adiv
.Download AXE dev tools so that you can clear any accessibility issues while coding : https://www.deque.com/axe/devtools/
Hope this helps.
1 - @waldosmutsSubmitted almost 3 years ago
Had to start over several times, even considered learning PHP just for this exercise but I pulled through in the end. Could still do with a lot of refactoring but it works as you'd expect. Might try this one again when I taught myself React.
@elroytoscanoPosted almost 3 years agoBrilliantly done! The animation of the reply box is brilliant 👍. The functionality is perfect as well.
There are some accessibility issues like an
alt
for theimg
element and anh1
element. Download AXE dev tools so that you can clear any accessibility issues while coding : https://www.deque.com/axe/devtools/Marked as helpful0