@Miss-Bentil
Submitted
@elliottkan
@Miss-Bentil
Submitted
@elliottkan
Posted
Nice work!
Noticed 2 minor things!
transition: ease-in-out 0.3ms' to your
button` elementHope this helps! Perhaps you could check my project out and offer some feedback too!
@Mojisolasmiles
Submitted
Positioning the card after resizing was extremely difficult and I had to do a lot of manipulations. I need a better understanding of INLINE-FLEX
@elliottkan
Posted
Hey!
Flexbox is definitely quite a tough beast to love! I like to think about breaking them down into small sized pieces for styling.
max-width
to the container to address the sizing issue instead of using margin.*
. By doing this, your .attribution
should sit directly underneath your card.Play around with @media
so the layout changes for responsive mobile design. You could then apply flex-direction:
to address the change in layout.
I believe it is best practice to use em
as opposed to px
for styling to cater for mobile first designs.
Look at HTML semantics to understand better how to label your content, there are several h
elements within your .wordings
div. I believe the h4 could be replaced with <p>
but I'm pretty new to this game still.
could apply a width:100%
to your img
so it fits within container.
I would recommend Kevin Powell to get some better understanding with CSS, he's an absolute weapon
Hope this helps!
@D4R0M
Submitted
@elliottkan
Posted
Hey Joseph,
Looks good! I recently finished my own challenge recently!
em
is preferable over rem
or px
. There seems to be some inconsistencies in that aspect in your code base. text-transform: uppercase;
on your .tag could address some styling inconsistencies. Just an FYI incase this was a deliberate styling choice.transition: all 0.3s ease-in-out;
to the button element will resolve the issueGood work! Hopefully you can have a look through my codebase and give me some feedback too!