Adham-16• 30
@Adham-16
Submitted
This is my Second task, I will be very happy for your helpful comments.
Don
@eldon6219
All comments
- Don• 380
@eldon6219
Posted
hello adham !
congrats on finishing your secound challenge here in frontend mentor where you will get better challenge after challenge :D
i like your solution and i think i can help you to update it and more helpful
- HTML
1- instead of using
<div class='container>try to use the HTML semantic elements more in this situation you should use<main>that should include all your codes and for better accessibility-CSS
1- try to use the CSS reset look it up it will help to reset all the properties in the code
2- make sure to use
min-height:100dvhso that the element get to the center of the page and using 'dvh' so that it's more responsive3- NEVER EVER use
width:300pxas the px insead use rem or em to make it more responsive same with the padding and the margin4- in box shadow we are trying to make it as realistic as possible so i think you should lower it a bit of something like this
box-shadow:0 0 12px 24px rgba(0,0,0,0.15)other than that you did a good job and keep going never quit you will get it eventually and you will become 1% better day after day i hope you find this helpful HAPPY CODING
Marked as helpful
0 - Pretty Kunene• 690
@nonoza
Submitted
Greeting coders !!
Please review my fav. I had to rebuild the project using the detail html element since it an faq. I added the icons but as soon as I load it to GitHub , it disappeared.
Your feedback is appreciated.
Don• 380@eldon6219
Posted
hello @nonoza !
you did a really good job in that challenge .. there is just two small details that you missed and i hope i bring your attention to them
1- when hovering on the questions that cursor is not the right one it should be "pointer"
2- in the mobile screen : when opening or clicking on a question all of them go back to the original align they should all stay center
3 - the FAQ title should be on the left no on the right
other than that you did a really good job and i hope u find this helpful
HAPPY CODING :D
Marked as helpful
0 - waru-guru• 60
@waru-guru
Submitted
My code is not being built and deployed in github and therefore my live site url doesn't show the design I made. Can I get help with that?
Don• 380@eldon6219
Posted
hello @waru-guru after you create the repositry in Github go to the repositry's setting and find the code and automation aside to the left
find the pages and change the branch from none to main (/root) it will generate and live url for your work and you can show your work perfectly ! hope u find this helpful and happy to help anytime ! happy coding
Marked as helpful
0 - Aakash-ziz• 10
@Aakash-ziz
Submitted
in this site i actually used margin-top :10% in container div but i know that its not a correct way to deal .suggest me a alternative way to do it
Don• 380@eldon6219
Posted
hey Aakash-ziz you did a good job trying to do this challenge for the first time congrats on finishing it ! although i have some notes starting with the margin top you are asking about ! the main reason the container didn't set in the middle is because you are seeting the body"s <height> to 100% instead change it to "100dvh" that will get the container centered in the page and you are missing the active state for the button so u can go back and finish it anytime hope u find this helpful
Marked as helpful
1
