Skip to content
OverviewSolutions
0
Comments
2
elder2701
@elder2701

All comments

  • elder2701•20
    @elder2701Posted 10 months ago

    Hi,

    Your solution is quite good; however, I have some recommendations on how you can improve it, if you don't mind.

    In your case, you can remove the <> before <section>. You already have the main node for correct JSX.

    Additionally, it would be better to split your app into different components. For example, you have a form, map, a list of position details, and position details. By using components, your app will become more organized, clear, and extendable.

    Hope it helps you

    0
  • Marcos Valenzuela•660
    @Dantalian5Submitted 10 months ago

    Another day, another project. As always, another interesting and fun challenge solved. Tools: React, React-Router, Tailwind, TypeScript. React was, without a doubt, a solid tool for solving this challenge, and it allowed me to delve even further into mastering this tool, the same goes for TypeScript. It was my first time using Tailwind and, honestly, it was a bit confusing at the beginning, but then the work with this framework became increasingly organic and fluid. I tried to optimize the web application as much as possible, in addition to ensuring that navigation was as smooth as possible, but I'm sure it can still be improved, and that there will be errors to correct and pieces of code to refine. As always, I appreciate your feedback and advice in advance.

    WorldCountries -- REST Countries API | by MV

    1
    elder2701•20
    @elder2701Posted 10 months ago

    Hi. This project is really good; you've done a great job. However, I have some comments for you that may help improve this solution.

    When using TailwindCSS, it's better to create a small design system. This allows you to reuse Tailwind classes and avoid repetition.

    For example. You have next block, which repeats at least 3 times

    <p className="font-semibold text-sm">

    Consider creating small components for elements like buttons, inputs, h1...hN, and so on, to facilitate reuse in the future.

    One additional point I'd like to highlight is the quality of the code base. Here are some general recommendations for the final version of the solution: try to eliminate unnecessary parts of the code and comments.

    I hope this helps you. Happy coding!

    Marked as helpful
    0