@egaiosowor
@JaeZzZ
Submitted
Hello, everyone! I'm unsure of positioning and margin best practices, so if you have any advice for me I would be super appreciative! Also, let me know if my code could be optimized. Looking forward to growing and getting better. Thank you :)
@egaiosowor
Posted
You’re welcome 👍🏾
@JaeZzZ
Submitted
Hello, everyone! I'm unsure of positioning and margin best practices, so if you have any advice for me I would be super appreciative! Also, let me know if my code could be optimized. Looking forward to growing and getting better. Thank you :)
@egaiosowor
Posted
Went through your source code, your HTML is clean and well structured. In your style sheet, I noticed some issues. I don’t feel it’s a good practice making use of so much positioning. On your body, you can just use display: grid and then place-items: center. It will place your main in the center of the page. Give your figure a width of about 80%, then give your figure image a 100% width, all these help eliminate the excessive use of positioning.
Marked as helpful
