I did this challenge to try and get more comfortable with CSS grid. Any feedback is appreciated, and feedback about grid is particularly welcome.
Erick F. Felix
@efs0-cod3All comments
- @JonMStevensSubmitted about 3 years ago@efs0-cod3Posted about 3 years ago
Your code looks great you should check some things like border radius and their position and the position of the attribution Instead of div I would change it to footer. Otherwise is looking good minor things. Hope it helps.
Marked as helpful1 - @ramirishoSubmitted about 3 years ago
Second project that I do, I will appreciate any advice, criticism and recommendation :D
@efs0-cod3Posted about 3 years agoFor the html issue you should have you div’s inside a main tag (landmark).
Looking pretty good on desktop view.
0 - @ArtemVMVSubmitted about 3 years ago
Hey everyone! Just starting, hope that's vital =D
@efs0-cod3Posted about 3 years agoGood solution Artem. I would remove the line-height and font-weight on .article for more aesthetics.
good luck!
0 - @abhishekanimatronSubmitted about 3 years ago
I struggled a bit to make it responsive, if anyone can look at the codebase and give me ideas as to how i make the card responsive would be super helpful! Thanks in advance! Also thanks frontend mentor!
@efs0-cod3Posted about 3 years ago-Try to change the #outer-container size from % to px. -Check the background too!
0