P
Marc Francisβ’ 520
@marcfranciss
Submitted
P
Emilia Burza
@eburza
All comments
- PEmilia Burzaβ’ 230
@eburza
Posted
Nice job :)
1 - Konradβ’ 370
@konradbaczyk
Submitted
What are you most proud of, and what would you do differently next time?
Next time I will change method of save the data in the form. I want to make buttons states permanently.
PEmilia Burzaβ’ 230@eburza
Posted
i like the way you personalized it :)
0 - Dylanβ’ 290
@dquinn089
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of the progress I made in understanding DOM manipulation and improving my debugging skills using the console. This project pushed me to dynamically update UI elements and manage user interactions effectively. However, next time, Iβd focus more on planning UI state management from the start to streamline the development process and explore advanced debugging tools for even more efficient troubleshooting.
What challenges did you encounter, and how did you overcome them?
I struggled the most with structuring the functions and using the proper JavaScript methods to work with JSON data arrays. It was challenging to figure out how to manipulate the data effectively and update the UI dynamically. I did some research on OOP and working with JSON data, which helped me learn how to better structure my code and use JavaScript methods to handle JSON data more efficiently.
What specific areas of your project would you like help with?
Iβd appreciate help with structuring JavaScript functions and organizing code for better readability and maintainability. Additionally, guidance on applying object-oriented programming (OOP) principles in JavaScript would be valuable for writing more modular and scalable code.
PEmilia Burzaβ’ 230@eburza
Posted
I really like your project, from code to rename, everything is thought through. It all looks nice π π
0 - Stevenβ’ 150
@Steven-Ang
Submitted
PEmilia Burzaβ’ 230@eburza
Posted
It all looks nice π π
But as you add it to your GitHub page and your future employer will definitely check it out, I would definitely recommend cleaning up Readme and delete files that aren't used by you in this project e.g. you have two readme files
0 - PPhilippeItsMeβ’ 110
@PhilippeItsMe
Submitted
What are you most proud of, and what would you do differently next time?
Two key issues :
-
On the desktop version, my share bottun output is inside the main section, i didn't find away to have it half inside the main section and half on the outer part. My main section has a howeflow : hidden so my absolute position could go out of the main section.
-
On the mobiel version, I cannot toggle my button. I can see the share button and go back to the initial design but then I am blocked
PEmilia Burzaβ’ 230@eburza
Posted
It looks nice, accept images do not load. With avatar, I can see alt, for the image on the left as I see you forgot to add it.
I don't know if leaving comments with code in HTML file is needed, remember that your future employer will go through your code, and he won't know why it's there
0 -
- Haylemeskel Haylemariamβ’ 30
@Hayle-HB
Submitted
PEmilia Burzaβ’ 230@eburza
Posted
Its so nice you customise this project and made it personal :) Project looks good π π
Marked as helpful
0 - Lucas Gabrielβ’ 70
@LucasGabriel2806
Submitted
PEmilia Burzaβ’ 230@eburza
Posted
Good job :)
0 - Hamid Riazβ’ 150
@hamidriaz1998
Submitted
PEmilia Burzaβ’ 230@eburza
Posted
Nice job, your project looks good π π
0 - Om Bhorβ’ 220
@kenzo0p
Submitted
PEmilia Burzaβ’ 230@eburza
Posted
Hi, as I see you forgot to add box shadow, because of it we can't see when elements starts and ends. There is also some issue with fonts, paragraphs are hard to read, contrast is too low as for me
Marked as helpful
0 - PEmanuele Fabrizioβ’ 220
@efabrizio75
Submitted
What are you most proud of, and what would you do differently next time?
Minimal amount of HTML, accessibility compliance.
What challenges did you encounter, and how did you overcome them?
I had issues switching images based on screen width, but then I remembered about the
picturetag and its use.What specific areas of your project would you like help with?
I'd like to know if it's possible to reduce further the usage of
widthandmax-widthproperties.PEmilia Burzaβ’ 230@eburza
Posted
Looks nice
I would work more on mobile version, it takes 100% width of available space, and it's enormous compared to web version
0 - PVasu Vallabhβ’ 190
@coding-vasu
Submitted
What are you most proud of, and what would you do differently next time?
I would use a
vitefrom next time for the live server, also createcssvariables in beginning to save timeWhat challenges did you encounter, and how did you overcome them?
It took me some time to get the padding & margins correct. I see we can use
optionskey on figma to check itWhat specific areas of your project would you like help with?
I need help with grid system
PEmilia Burzaβ’ 230@eburza
Posted
looks nice
link to repository is not working, so I can't check the code
Marked as helpful
0
