Skip to content
OverviewSolutions
26
Comments
5
Dylan Guaquier
@dylanguaquier

All comments

  • Dylan Guaquier•340
    @dylanguaquierPosted about 1 month ago

    Be care, on your @media you put padding (with VW also, that's not a good idea).

    So, in desktop mode, your text is no more align to your cards.

    (i am using ultra wide screen, that's probably why but that not a good solution to put VW) so it scale with my screen badly

    Marked as helpful
    1
  • Dylan Guaquier•340
    @dylanguaquierPosted over 1 year ago

    Hey, i've put myself the overflow-y hidden on media queries 1440px cause there is no need to scroll here on desktop but yeah, i understand.

    I mean if that's a component, media queries should be on the component itself and nowhere else :/. That is also mean that the background-color or padding on the body shouldn't be useful on this types of challenge.

    And thanks a lot for clamp() i have no clue about what this is, i'm gonna read it and learn it for the future. Thanks for your review !

    Ps : i haven't seen that there was probably something below the header component (there is something white below) so yeah, my bad i will get out the overflow-y

    0
  • Dylan Guaquier•340
    @dylanguaquierPosted over 1 year ago

    index-8c42ae4f.js:40 Uncaught TypeError: Cannot read properties of undefined (reading 'isChecked') at index-8c42ae4f.js:40:60534 at Array.map (<anonymous>) at Dd (index-8c42ae4f.js:40:60379) at gi (index-8c42ae4f.js:38:19468) at Po (index-8c42ae4f.js:40:3134) at Za (index-8c42ae4f.js:40:44482) at Ya (index-8c42ae4f.js:40:39510) at vd (index-8c42ae4f.js:40:39441) at br (index-8c42ae4f.js:40:39300) at Uo (index-8c42ae4f.js:40:35718)

    This is the error in the console

    Marked as helpful
    1
  • Dylan Guaquier•340
    @dylanguaquierPosted over 1 year ago

    Great job :), i don't know if it is only me but when i have spam delete thoses tasks everything disapeared

    Marked as helpful
    1
  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarSubmitted over 1 year ago

    Hi there 👋, I’m Melvin and this is my solution for this challenge. 🚀

    🎁 Features:

    🛠️ Built With:

    • React JS. ⚛️
    • React Hook Form. 📝
    • Framer Motion. 🎬
    • TailwindCSS. 🎨
    • npm - prettier - prettier-plugin-tailwindcss. 📦

    Any suggestions on how I can improve and reduce unnecessary code are welcome!

    Thank you. 😊✌️

    Fylo dark theme landing page (React JS + Tailwind CSS + Framer Motion)

    16
    Dylan Guaquier•340
    @dylanguaquierPosted over 1 year ago

    Wow, that's impressive, congratulations

    1