I had trouble with background images, what's a better solution for them? I also noticed the testimonial cards are not responsive in production, I couldn't get them to automatically center with flexbox, any suggestions here?
Dawid
@dwddgszAll comments
- @antonioscardoviSubmitted about 4 years ago@dwddgszPosted about 4 years ago
Hello
At this
(max-width:768px)
you can try addmargin:0 auto
to.bottom .test
. It should do the job. Keep up good work1 - @alejatraveler98Submitted about 4 years ago
Any feedback? Thank you :D
@dwddgszPosted about 4 years agoHello!
I think you could add some space between sections. Also you didn't add quotation marks to
testimonial-content
section.Anyway, it looks really good. Bravo
1 - @jomefavouriteSubmitted about 4 years ago
Feedbacks are welcomed
@dwddgszPosted about 4 years agoHello!
You didn't include background patterns. I think your project would look much nicer with them.
Apart from that, it looks clean. Good job
1 - @BrodanISubmitted about 4 years ago
Feel free to add your feedback on the code. This is the first project I've done on my own, so open to any and everything.
This time I did all the coding myself, no libraries used.
@dwddgszPosted about 4 years agoHi!
I think that you used media queries to early. At those
375px
there is no much space for content. Also I'm sure that soon you will learn some helpful techniques (like float, flexbox or css grid) that will make creating page layout much easier for you.Anyway, congrats on completing this challange. Your final result looks good! I hope you will continue your journey.
0 - @shaw12Submitted about 4 years ago
How do I improve this?
@dwddgszPosted about 4 years agoHello!
You can use
overflow:hidden
on.image_sec
and then make use ofillustration-box-desktop.svg
. Also you could add those two background patterns for example by creating two items with border and transforming them.Anyway, good job. Hope I could help.
1 - @BlackTech718Submitted about 4 years ago
Any Feedback is welcomed.
@dwddgszPosted about 4 years agoHello
Congratulations on completing this challenge!
I think that at
500px
window width img located in div with classfour
is to stretched. Also you could name your classes depending on content inside, it helps in understanding your code.Hope I could help
0 - @LeUrbanSubmitted about 4 years ago
Hello guys. Here's my first web page. I'd need your reviews. Thank you!
@dwddgszPosted about 4 years agoHello!
Firstly, congratulations on your first web page.
I think that you set breakpoint to early, at
500px
content is really tight. Also you didn't add those background patterns. I belive that you can fix this.0 - @GribichexSubmitted about 4 years ago
Real beginner here, still struggling to center things and catch details with eyes only so it's far from perfect. Any suggestions to remove bad practises I may have done on this first challenge ?
Thanks for your kind feedback !
@dwddgszPosted about 4 years agoHello!
From
768px breakpoint
to something like1200px
there is no space for all stars, so they collapse. Maybe you could fix this usingmin-width:120px; display:flex;align-items:center
on.star-row
.Anyway, good job
1 - @ApplePieGiraffeSubmitted about 4 years ago
Hey, everybody! 👋
This was a very fun challenge from which I learned to carefully think about how I markup things in HTML and position them in CSS. 🤔
I borrowed some animations from Animate.css and played around with the
animation-duration
property to create a messaging animation in the phone (which I really think adds some life to the page). 🎉I'm also rather pleased that my code didn't end up too messy or disorganized after attempting a CSS illustration like this. 😉
As always, feedback is on both my solution and my code is both welcome and greatly appreciated! 👍
Happy coding! 😄
@dwddgszPosted about 4 years agoHello!
Really like those animations, they are simple and cool. I didn't know about Animatie.css so I'll check this out.
I would also add some pulse effect to this input, but maybe it would be too much.
Anyway, good job
1 - @Ramkumar-45Submitted about 4 years ago
First of all, I have coded for the dark-theme. after that noticed the instruction is given as switching from a light theme to a dark theme. I have coded opposite of given instruction
@dwddgszPosted about 4 years agoHello! From around
770px
width to1000px
cards are to tight for content and maybe you could add function that will change theme name depending on which one is chosen. Anyway, great job1