Skip to content
OverviewSolutions
9
Comments
6
Duncan Chege
@duncan-chege

All comments

  • David Almonacid•70
    @DavidAlmonacidSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of the result

    What challenges did you encounter, and how did you overcome them?

    The most challenging part was making the responsive design

    What specific areas of your project would you like help with?

    It was a starter project, so I don't need an extra help in this moment.

    Newsletter sign-up form

    1
    Duncan Chege•200
    @duncan-chegePosted about 2 months ago

    Please update your project URLs (both live site and GitHub repo). They are broken

    0
  • Duncan Chege•200
    @duncan-chegePosted about 2 months ago
    • On mobile: Your avatar image and text are overlapping each other and your design for the share button popup is not the same as the design provided. Also, in the design provided, the share popup sits on top of the avatar, yours sits below the avatar
    • You forgot to add the Manrope font to your <p> tags. They're falling back to the default system font
    0
  • ShadowKiD14•340
    @ShadowKiD14Submitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    Handling async API requests using fetch() in JavaScript.

    Next time I would try axios.

    What specific areas of your project would you like help with?

    Adding animations when the advice loads up. It currently looks too choppy.

    Adviice Generator App

    1
    Duncan Chege•200
    @duncan-chegePosted 2 months ago

    Hey, I used axios. It was pretty simple to implement. You can check out my code here: https://github.com/duncan-chege/advice-generator

    Marked as helpful
    0
  • Duncan Chege•200
    @duncan-chegePosted 2 months ago

    I love the counter-effect when the age is calculated! However, please add day and year error validation when the button is clicked

    0
  • Duncan Chege•200
    @duncan-chegePosted 2 months ago

    Love how the design looks! However, since it's a small design, please make everything fit within the browser window without being cut off "Challenge by Frontend Mentor. Coded by José Alejandro Herrera Franco." is cut off at the bottom

    0
  • Duncan Chege•200
    @duncan-chegePosted 2 months ago

    Your application looks good! However, your button icon isn't loading (the image URL link is broken). Look into it

    Marked as helpful
    0