Skip to content
OverviewSolutions
11
Comments
5
P
Diego Serrano
@dserranoi

All comments

  • oo2smh•100
    @oo2smhSubmitted over 1 year ago

    Some Struggles

    • Started building the project without looking at the screen-size. After building for awhile, I realized that it broke during the smaller screens and had to go fix it. Next time, I want to start off from the smallest version
    • Had difficulty with max-width and min-width
    • Overlapping the summary component underneath the results component was difficult. I ended up using negative margins, but felt like this is not an elegant way to solve the problem

    Results-Summary Component (Responsive Layout)

    1
    Diego Serrano•180
    @dserranoiPosted over 1 year ago

    For the overlapping issue, you really don't need to overlap them, they look overlapped in the design but really you can approach the solution in a way where you have a parent container let's say a DIV and inside it you have 2 children divs. You can apply flex display to the parent div, and in the div that wraps Your Result apply the border radius property as well to the parent Div.

    I am sure that should help to accomplish that piece..

    Marked as helpful
    0
  • Ambre•170
    @Yunie08Submitted almost 3 years ago

    Hi everyone ! Just finished this one and I think the experience gained doing all those challenges is finally starting to show. It still took me quite some time to finish but it felt like I knew a bit more what I was doing. Anyway, please let me know what you think 😊 Thanks, and happy coding!

    Responsive section using CSS grid and flexbox with SASS

    1
    Diego Serrano•180
    @dserranoiPosted almost 3 years ago

    pretty impresive how you are aligning the ratings and quotes boxes.. I did the same challenge using grid, but your solution looks cleaner. i just love it good work

    0
  • Diego Serrano•180
    @dserranoiSubmitted almost 3 years ago

    I am strugling quite a lot, bc figma files mockups are designed for 1440px.. are you guys adding media query for something bigger than that ?

    SASS preprocesor, media queries

    3
    Diego Serrano•180
    @dserranoiPosted almost 3 years ago

    Awesome, thank you so much for such detailed feedback.

    0
  • Diego Serrano•180
    @dserranoiPosted almost 3 years ago

    1.- is nice how to are care about your css code to work in all browsers. 2.- also i see you are making heavy use of shorthand as margin: top right left bottom; that's cool that way you type less code.

    keep coding :)

    Marked as helpful
    0
  • Diego Serrano•180
    @dserranoiPosted almost 3 years ago

    Hey @mikkool - cool page. 1 comment if you don't mind. 1.- Your repository is not found. .

    Marked as helpful
    0