@jordan369639Submitted almost 2 years ago
gettting the language and borders from api is quite tricky im unsure about borders name for some countries the are no values for border, please let me know if there are any mistake
Maciej
@dreamspiceAll comments
- @dreamspicePosted almost 2 years ago
Git add, Git commit, Git push
Only this. And generator new report on this site.
0 - @jordan369639Submitted almost 2 years ago
gettting the language and borders from api is quite tricky im unsure about borders name for some countries the are no values for border, please let me know if there are any mistake
@dreamspicePosted almost 2 years agoNice !
How do u implement functionality: ex. type 'pol' and country starts with 'pol' render without submit form? I need to check your code.
U can filter countries from A-Z, with filter method:
state.data.sort(function (x, y) { let a = x.name.toUpperCase(), b = y.name.toUpperCase(); return a === b ? 0 : a > b ? 1 : -1; });
Also add alt attribute to all flag images, close everything in semantic elements, ex. <header></header>, <main></main>, and add aria-labelledby, aria-label and label for select el.
Marked as helpful0 - @Vitor-HenriqueASSubmitted about 2 years ago
I was wondering how to change the color of an svg, for example the color of musical notes, is it possible?🎵
Any feedback is welcome.🚀
@dreamspicePosted about 2 years agoU can easily change svg color in Figma. Nice work, code looks good :)
0 - @dreamspiceSubmitted over 2 years ago
Hi,
I thing this looks good. I gave up with that hamburger menu but i will try do it.
I tried first time "mobile first" concept and it's great!
Have a nice day :)
@dreamspicePosted over 2 years agoHi, thank you for reply.
Mmmm...
U use this div because i can't add white padding for text but i can do it now.
Ok, then this <h1>We are creative</h1> item should be outside this div?
<header> <h1>...</h1> </header>not
<header> <div class="header-text> <h1>..</h1> </div> </header>0 - @dreamspiceSubmitted over 2 years ago
Hi,
I thing this looks good. I gave up with that hamburger menu but i will try do it.
I tried first time "mobile first" concept and it's great!
Have a nice day :)
@dreamspicePosted over 2 years agoI will check it later. Thank you.
Font's for <p>, <a> doesn't work because i forgot to import font-weight: 400, in style guide i found only 600 / 700, 900.
0 - @maksat07Submitted almost 3 years ago@dreamspicePosted over 2 years ago
Hi, nice work.
Desktop version is nice.
I see some accesibility issues (img alt=""), heading and with semantic tag. Use <nav> tag instead of <div class="nav">.
For mobile version try set min-height for a few containers.
All the best :)
Marked as helpful0 - @dreamspiceSubmitted almost 3 years ago
Sadly, without JavaScript :( However check it.
I always start creating on ~2.5k width, then mobile, then desktop.... Maybe i will try mobile first.
First time use SASS - finally less and cleaner code.
How to put div / footer down when we can scroll our site?
@dreamspicePosted almost 3 years agoHey !
Thanks for feedback.
I think label is for only mhmmm... checkboxes and radio type input.
I saw something like this:
<div> <label for="email"> <input type="email" id="email"> </label> </div>Use div in that case or not?
Thanks for that validation.
All the best.
0 - @dreamspiceSubmitted almost 3 years ago
Sadly, without JavaScript :( However check it.
I always start creating on ~2.5k width, then mobile, then desktop.... Maybe i will try mobile first.
First time use SASS - finally less and cleaner code.
How to put div / footer down when we can scroll our site?
@dreamspicePosted almost 3 years agoHi !
Thank you for reply and advices :)
I have updated my code. Thanks for video but something doesn't work i will figure out how to fix it.
All the best.
1 - @dreamspiceSubmitted almost 3 years ago@dreamspicePosted almost 3 years ago
Hi, thank you for reply and advices :)
I forgot to use semantic tags. Yeah, 'main' is probably the best for this case.
I use 'h2' because i dont' want to change font-size but now i know it's bad practice.
I will upgrade that and add media queries for 1440px width.
All the best.
1
