Daniel Dominguez
@dominguez-daniel
All comments
- PDaniel Dominguezā¢ 150
@dominguez-daniel
Posted
Very clean!
0 - Atatraā¢ 170
@Atatra
Submitted
What are you most proud of, and what would you do differently next time?
I realize how much I prefer vanilla CSS over TailwindCSS.
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Awesome job, HTML looks very semantic and styles are nicely organized.
1 - Gideon-wā¢ 90
@Gideon-w
Submitted
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Hi
@Gideon-w
,Your HTML will marked-up up well - rather than using
div
for the card, anarticle
would better resemble these independents bits of content.Marked as helpful
0 - Olenaā¢ 190
@helenhapp
Submitted
What are you most proud of, and what would you do differently next time?
I tried my best to make it look good on different screen sizes, and to make it close to the design, paying attention to all the details.
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Hi
@helenhapp
, your markup is clean and semantic, nice work!0 - Solomon Obanijesu Philipā¢ 1,200
@Hackerbot24
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of completing this challenge, i plan to do any thing i am been corrected about differently.
What challenges did you encounter, and how did you overcome them?
I encounter a problem while uploading the website, but i watch few toturials online to rctify.
What specific areas of your project would you like help with?
i am open to leaning every area of it.to know more
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Nice!
Marked as helpful
0 What challenges did you encounter, and how did you overcome them?
Hi there š, Iām Rashid and this is my solution for this challenge. š
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. š
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Hi
@Rashid0101
, overall your solution is solid, I really like the css reset you used.Marked as helpful
0- Abedhousaryā¢ 1,320
@abedhousary
Submitted
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Hi
@abedhousary
I noticed a few things about your solution I though would be good to note:- Visually, the card's padding seems to be a little off along with the overall flow of the content.
- on smaller screen sizes, the content overlaps with each other
- from a semantic html perspective, the entire card is written using
div
element rather than semantic elements. This can cause accessibility issues.
I hope this helps! -cheers
0 - Rakesh Dasā¢ 90
@Rakesh4688
Submitted
PDaniel Dominguezā¢ 150@dominguez-daniel
Posted
Hi
@Rakesh4688
, a few comments about your submission:- From a semantic HTML perspective, I think an
article
tag is more descriptive than adiv
tag -div
tags are generic. - I also noticed the paragraph is missing the first word 'Scan'.
- Visually, the card's width seems smaller than the design, typically the container should be the width of the content it contains, you can give the content a
max-width
without hardcoding a specificwidth
.
0 - From a semantic HTML perspective, I think an