Skip to content
OverviewSolutions
8
Comments
8
P
Daniel Dominguez
@dominguez-daniel

All comments

  • Daniel Dominguez•150
    @dominguez-danielPosted 3 months ago

    Very clean!

    0
  • Atatra•170
    @AtatraSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    I realize how much I prefer vanilla CSS over TailwindCSS.

    Testimonials using CSS Grid

    1
    Daniel Dominguez•150
    @dominguez-danielPosted 3 months ago

    Awesome job, HTML looks very semantic and styles are nicely organized.

    1
  • Daniel Dominguez•150
    @dominguez-danielPosted 3 months ago

    Hi @Gideon-w,

    Your HTML will marked-up up well - rather than using div for the card, an article would better resemble these independents bits of content.

    Marked as helpful
    0
  • Olena•190
    @helenhappSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I tried my best to make it look good on different screen sizes, and to make it close to the design, paying attention to all the details.

    Product preview card component

    2
    Daniel Dominguez•150
    @dominguez-danielPosted 4 months ago

    Hi @helenhapp, your markup is clean and semantic, nice work!

    0
  • Solomon Obanijesu Philip•1,200
    @Hackerbot24Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of completing this challenge, i plan to do any thing i am been corrected about differently.

    What challenges did you encounter, and how did you overcome them?

    I encounter a problem while uploading the website, but i watch few toturials online to rctify.

    What specific areas of your project would you like help with?

    i am open to leaning every area of it.to know more

    Responsive, mobile friendly using CSS

    1
    Daniel Dominguez•150
    @dominguez-danielPosted 4 months ago

    Nice!

    Marked as helpful
    0
  • Rashid•120
    @Rashid0101Submitted 4 months ago
    What challenges did you encounter, and how did you overcome them?

    Hi there 👋, I’m Rashid and this is my solution for this challenge. 🚀

    Any suggestions on how I can improve and reduce unnecessary code are welcome!

    Thank you. 😊

    Social links profile

    2
    Daniel Dominguez•150
    @dominguez-danielPosted 4 months ago

    Hi @Rashid0101, overall your solution is solid, I really like the css reset you used.

    Marked as helpful
    0
  • Daniel Dominguez•150
    @dominguez-danielPosted 4 months ago

    Hi @abedhousary I noticed a few things about your solution I though would be good to note:

    • Visually, the card's padding seems to be a little off along with the overall flow of the content.
    • on smaller screen sizes, the content overlaps with each other
    • from a semantic html perspective, the entire card is written using div element rather than semantic elements. This can cause accessibility issues.

    I hope this helps! -cheers

    0
  • Daniel Dominguez•150
    @dominguez-danielPosted 4 months ago

    Hi @Rakesh4688, a few comments about your submission:

    • From a semantic HTML perspective, I think an article tag is more descriptive than a div tag - div tags are generic.
    • I also noticed the paragraph is missing the first word 'Scan'.
    • Visually, the card's width seems smaller than the design, typically the container should be the width of the content it contains, you can give the content a max-width without hardcoding a specific width.
    0