@Divasraj1
Latest comments
- @dolomita28
Hi Divasraj, Well done! I would only suggest you a sligth improvement. You could improve your layout adding a height:100vh to your body css, so the card gets vertically centered. Best
- @pawelpiotrowski38@dolomita28
Hi @pawelpiotrowski38 Great job! I would only suggest you using a picture html tag instead of having both images and then hiding/showing them from the css file. Please see this [picture_tag] (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture) and even better [responsive_images] (https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images) Best
Marked as helpful - @estaarrr@dolomita28
Hi Esther, You did a great job. There can be many different solutions to achieve the same. I would only suggest you avoid using px units. It's better to get used to use %, rem or em units. You could also take advantage of flexbox techniques (which I've seen you know how to use them) even for nested containers so you don't need using margins to center items. Finally, check out the report above with some accessibility issues to get extra hints. Best
- @prettyBcoding@dolomita28
Hi, you could define a width to the bg div, so the card doesn't look so big. Then, use a padding for appliying the inner space between your card and image. You could also, instead of using margin to center containers (in this case the card), make use of flexbox. Hope it helps Best
- @Richy55-max@dolomita28
Hi Arnaud, Congrats for such a great work you've done! My only suggestion would be, try to avoid using pixels whenever possible. It is better to get used to use %, rem or em units. Furthermore, although there's a bit of controversial going on, it is better to load fonts earlier in the html instead of importing them in the css file. Best
Marked as helpful - @Cmdliner@dolomita28
Hi Adeyemi, Well done! You could remove the flex class at <div class="payment-amount flex"> so that these two items of that dive get closely aligned.
Marked as helpful
