@Ging3rmintSubmitted over 2 years ago
David Andrea
@djblackettAll comments
- @djblackettPosted over 2 years ago
I like how the infinite slider for the trending videos looks, but because it does not scroll, it is a bit awkward on a laptop. I have to click and drag (or touchpad equivalent) to move the slider. Just wanted to throw that out there.
I improved the layout on mine by looking at some of your code, so thanks for commenting on mine and tipping me off to that.
0 - @kamrulsaadSubmitted over 2 years ago
Hey, this is my first big project, I am kind of lacking in making this page responsive. I would like to submit now for I want to know how others have done it by checking their solution. Please leave any suggestions that might help me finish this project in a better way.
@djblackettPosted over 2 years agoI had the exact same issue with the "transform" and "stand-out" cards being too big at certain screen widths. You can use use "aspect-ratio: 1" to force them to be squares like the images next to them. If they run off the page to the sides despite aspect ratio being defined, you can make sure your margins and padding are not too big (using %s will help), and you could also set a max-width property to force them smaller.
Marked as helpful0 - @ndgdlSubmitted over 2 years ago
First challenge on Frontend Mentor, had a lot of fun :)
I struggled with the responsiveness:
- first I tried given a width in vh (not good results on big screens)
- then I tried to use fit-content as a width property but ended up with 1 line advice on big screens
- I ended up giving a given width in pixels Is there a better way?
Regarding the fetch request, I was wondering if there is a way to prevent spamming the requests. The easiest way for me was disabling the button with a timeout of 1 sec, but not sure if it's best practice.
Any other feedback would be welcome!
@djblackettPosted over 2 years agoI'm not sure if you made a typo in your question or not, but there is a corresponding vw unit for getting the percentage of the viewport's width. That would be more predictable that using vh for width. I often use that or percentages.
You can also change the percentages in a media query if it is not quite behaving the way you want at certain sizes.
Marked as helpful0 - @TKadyearSubmitted over 2 years ago
I find difficult do the drag and drop in mobile because the Touch events does not work as Drag and Drop API . Any recommendations about the drag and drop? If anyone used a library for drag and drop, which one would you recommend? Thanks
@djblackettPosted over 2 years agoI used Atlassian's React Beautiful DnD library for my todo list app. I don't really know how it compares to others since it is the only one I tried, but it worked quite well. Here's a link to an article I used to help implement it: React Beautiful DnD
Marked as helpful0 - @KaskaS-OSubmitted over 2 years ago
Hi, This is my first attepmt to this challenge (without the bonus functionality). In the (close) future I'm going to add sorting the list by drag and drop. Does anybody have and advices on this behalf? My plan is to use react-beautiful-dnd library, but maybe some of you have other suggestions? All the remarks on the code and advices for future development will be appreciated.
All the best!
@djblackettPosted over 2 years agoNicely done. Your code is very readable too. I used Redux when I did this project, but it was definitely overkill and made the codebase messier than yours is. So it stands out to me how much cleaner yours is by comparison.
Implementing the DnD wasn't too bad. The documentation was fairly straightforward. I ran into the problem of my list glitching a bit after dragging stuff around, but I'm pretty sure it was because I was triggering extra renders that weren't necessary. I refactored my code and simplified things, and the problem went away. I was likely using useEffect incorrectly. Looking at how well your code is structured, I think you will have an easier time implemeting DnD than I did.
Marked as helpful0 - @SheGeeksSubmitted almost 3 years ago@djblackettPosted almost 3 years ago
Very nice. I just completed this one too, and it's interesting how completely different our approaches were. I overengineered mine on purpose, but I really like how simple you kept your code.
1 - @djblackettSubmitted almost 3 years ago
At certain zoom levels, I can see a tiny green circle between the white border surrounding the avatar pic and the avatar itself. Any idea on how to eliminate this?
@djblackettPosted almost 3 years agoI figured out how to eliminate the green circle that sometimes appeared. I just set the background-color of the avatar img to white.
0
