Skip to content
OverviewSolutions
10
Comments
3
P

dionysia-lemonaki

@dionysia-lemonaki120 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • P
    dionysia-lemonaki•120
    @dionysia-lemonaki

    Hi, I'm going through the Building Responsive Layouts learning path, and your solution was picked for review. It looks like the repo might have been deleted? When I click 'View Code,' it takes me to a 404 GitHub page.

  • P
    dionysia-lemonaki•120
    @dionysia-lemonaki

    Congratulations on completing the challenge!

    I noticed that your card isn't fully centered in the viewport.

    margin: 4rem auto; on .card horizontally centers it but doesn't center it vertically.

    Instead, you can turn the body into a flex container to center .card both horizontally and vertically:

    body {
 min-height: 100vh;
 display: flex;
 justify-content: center;
 align-items: center;
}

    I hope that helps.

  • P
    dionysia-lemonaki•120
    @dionysia-lemonaki

    Congratulations on completing the challenge! Your project is looking really good.

    Just a small note on the HTML: Heading levels should only increase by one, so because you use h1 for the main title, the heading level under it should be h2, so it should be <h2>Preparation time</h2>. The font-size in the design does not play a role – it is about creating a hierarchy. This article from Deque University explains this concept.

    Also, for the font-size in your CSS, it is not considered a good practice to use pixels – it is best to use rem instead. This article by Grace Snow explains more on the topic.

    Marked as helpful