Skip to content
OverviewSolutions
3
Comments
6
Mohamed Donzo
@demahom18

All comments

  • Mohamed Donzo•165
    @demahom18Posted over 3 years ago

    Hey how you doing Wendiie, great job on this one (y). To get rid of scrollbar, try overflow-y: hidden to your body

    0
  • Mohamed Donzo•165
    @demahom18Submitted over 3 years ago

    This is probably the most advanced website I've made so I would reaaly appreciate any advice to improve my code. It is full responsive with some animations (first time trying gsap). I learned a lot doing this challenge!

    PHOTOSNAP multipage- with Vue3 and Sass

    2
    Mohamed Donzo•165
    @demahom18Posted over 3 years ago

    Hi ApplePie, Thank you for your feedback. I fixed those errors but there are still 2 remaining. I don't really think they are important. One is because there 's no text inside a 'a' tag (it is the svg logo) and the second one is because the animation does not display the text before you scroll to it.

    0
  • Daryl Carr•70
    @daryl-cSubmitted almost 4 years ago

    Hi!

    I've used 11ty together with Andy Bell's CUBE CSS approach. I've been a general developer for a while now but I really want to improve my core frontend skills so any advice would be greatly appreciated. Anything from the structure of the CSS, refactoring templates, improving accessibility etc would be warmly welcomed :)

    One thing I would like to look at more is some of the animations/transitions for the nav opening/directors boxes toggling/the form submitting.

    Another thing that was a little difficult was going back to using vanilla js for the validation stuff instead of react. Not sure if my approach is very well structured but it seems to work at least.

    Thanks in advance for any input!

    Daryl

    Mobile first using Eleventy and Sass (with a CUBE CSS -ish) approach

    5
    Mohamed Donzo•165
    @demahom18Posted almost 4 years ago

    Hey Daryl, I find your solution really great. The only one thing you can do is adding a transition on your hover effects and it would be perfect

    1
  • Mohamed Donzo•165
    @demahom18Posted almost 4 years ago

    hello Bouhaouliane, just to tell you that your github link doesn't work

    0
  • Sook-Yan Hue•40
    @syhueSubmitted almost 4 years ago

    Still not sure how to toggle the dark or white theme using angular material. Will improve my skill on it.

    Do appreciate and welcome any reviews on my code.

    REST Countries API

    3
    Mohamed Donzo•165
    @demahom18Posted almost 4 years ago

    Hey how you doing, I just did the same few days ago (with Vue 3) and I can help with some little advices:

    1. the short name you get is the alpha3Code. You have to find the country's full name by the alpha3Code.
    2. Google (prefers-color-scheme) you will find how to do it
    3. Can't say much about your code. I dont know react
    1
  • Mohamed Donzo•165
    @demahom18Posted almost 4 years ago

    Hey I just did the same challenge with Vue, and I found some issue in your demo site. There s a bug with hover effect (I tried it in Microsoft Edge)

    1