Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @deejayjay

    Posted

    I like the animation and all. However, it seems like the JavaScript which loads the advice is not working. Also, instead of reloading the entire page at regular intervals, reload just the advice. I think it gives a better user experience. Good job on completing the challenge.

    Marked as helpful

    1
  • @deejayjay

    Posted

    Looks great. My only suggestion is to set a min value for your input elements so that it won't accept -ve values at all. Right now, users can try to input -ve numbers by using arrow keys. For day & month, set min value or 1 and max value of 31 and 12 respectively.

    1
  • @deejayjay

    Posted

    Good job on making the page look so close to the mock up. My advice is to focus on making your HTML semantic. Also, I noticed that you have hard coded the advice instead of loading the advice from the Advice Slip API. If you are new to JavaScript, this can easily be implemented referring the example in this page: "https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch". If you have any questions, feel free to ask via slack. Good luck!

    Marked as helpful

    1