All comments

• 

  Vynny LonlySoft•160

  @LonlysoftSubmitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  For this one, my prouds are mostly because the design being flat made me figure out most of what should I do in the design at first sight. About what to do next time... part of the code got scrambled because of inline svg.

  What challenges did you encounter, and how did you overcome them?

  A challenge for me is more about sizing the content to get as close as possible to the original design. This actually can't be overcomed easily because it's more of a "try and error" situation.

  

  Blog preview component

  2

  00
  

  decorator-factory•40

  @decorator-factoryPosted about 2 months ago

  • The card is not responsive. Because it's using a fixed width, it will overflow when there's not enough space. I would use a max-width instead: hint the browser instead of forcing a specific value
  • The heading is a bit too small on desktop. It should be 24px (this way it is the main point of focus when someone is browsing a page). For the same reason the publishing date and the tag should be a bit smaller: they are secondary details. I also think the text is easier to read with a line-height of 1.5 on the description
  • I'm not sure why the image is included as inline SVG. It's definitely better to include images as separate files (for caching, reusing the image, editing the image, and code readability)
  • A small accessibility improvement would be using the <time> tag for the post date

  1
• 

  Luis Gonzalez•70

  @luisgonzalez2001Submitted 2 months ago

  What are you most proud of, and what would you do differently next time?

  I feel good about these first steps I'm taking in web development, I hope to improve over time to be able to build better things.

  What challenges did you encounter, and how did you overcome them?

  In this first project I did not have any difficulties due to the simplicity of the project. I hope in the future to find more challenges in more robust and interesting projects.

  What specific areas of your project would you like help with?

  None.

  

  QR component with HMTL and CSS

  2

  40
  

  decorator-factory•40

  @decorator-factoryPosted 2 months ago

  This looks good. I have a few nitpicks if you want to be "pixel perfect" with the design:

  • the card is missing a slight shadow
  • the card is a bit too large, and the text should be slightly narrower than the image. I think the text looks better when it is more "clumped together", but that's subjective

  Marked as helpful

  0