@khanimran17Submitted about 2 months ago
P
Alexander Roan
@dearestalexanderAll comments
- @dearestalexanderPosted about 18 hours ago
I like the way you did three different versions with an intermediate layout for devices like tablets.
0 - @RetroApeSubmitted 6 days agoWhat are you most proud of, and what would you do differently next time?
Used Grid for the first time. Awesome tool!
Made the transition with the help of Flexbox at a breakpoint, which made things much easier with the mobile layout.
There is nothing I would do differently at the current state of my skills.
What challenges did you encounter, and how did you overcome them?Using Grid.
Went through a couple of hours of research and there were no notable problems.
I had a small problem with positioning an icon on each Card, using
::after. The icon was refusing to touch the bottom of the border because the icon's "container" (orcontent) was bigger (higher) than it should have been.- Setting the height of the "container" to be the same height as the icon solved the problem
@dearestalexanderPosted 5 days agoLooks pretty good, nothing much to add. Nice job getting it so close by eye. I guess the shadow colour difference was an intentional choice.
I'm amazed how different out CSS is for the same exercise. Quite different approaches.
I think you said you used flex for mobile and grid for desktop. I used a mix of flex and grid for both. Grid for the cards, but flex on various objects to do things like position icons. It's very easy to switch grid between desktop and mobile just a couple of lines of CSS so might be worth trying that out as well to get more practice with grid. Unless you already know how.
1 - @techie084Submitted 25 days ago@dearestalexanderPosted 17 days ago
Hi, just at a glance a few things seem different
- background color
- product name and price font
- letter spacing on 'perfume'
- spacing between different text elements h1, p etc.
0 - @TomSifSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
"For the first time, I started with a mobile-first approach and adjusted the breakpoints with media queries. It's probably my most advanced project so far, even though it's still simple. I spent way too much time fine-tuning some design details, such as the bullet points in the list, which needed to be centered in the paragraphs. There's probably a quicker method, but I eventually managed to adjust everything as expected. The project is fully responsive—probably a bit rough around the edges, but I'm still pretty proud of it!"
What challenges did you encounter, and how did you overcome them?"The darn bullet point that needed to be centered in the middle of the paragraph gave me a hard time. I had to use ::before with content: "\2022" and position: relative, then adjust the position of the last bullet with padding. And for some reason, it took me hours... At least now lists hold no more secrets for me—well, until proven otherwise!"
What specific areas of your project would you like help with?"I'd like to know the best way to implement margins so that they scale with the screen resolution. I had to use media queries at different resolutions, but the result feels a bit choppy. There must be a better way to do it."
@dearestalexanderPosted 2 months agoHi Thomas,
I'm not an expert, but a few comments:
- You may consider putting some comments in your html to explain your approach
- I'm not sure you need so many <div> and <sections>. When I look at <section> guidance, that generally applies to a larger peice of content. And you should only use when something more specific doesn't fit. I chose to put the whole recipe component into an <article> as it feels like an <article>, fits well with the examples in W3C guidance. Within that <article> I only felt I needed one styling <div> for the differently formatted 'preparation' section. All other content could be style partically with by using 'main'. And it's easy to space it all out with flex, padding and margins as needed.
CSS
- I recommend reading up on block element method , it's a good way to structure class names to make it easy to follow the logic of what is used where.
- For accessibility and re-usability it seems one good practice to get into the habbit of following is to apply specific styles mostly on classes. When you get to more complex designs avoiding styling on html tags mean there's less likely for specific adjustments to have unintended consequences. Of course I think base styling to body and main is normal, but styling on h1, p, ul etc. seems might be better to use classes.
- It's possible to make this responsive without using any @media queries at all. You can use width: min() and specific a size in ch for desktop and a size in & for mobile.
- I think you can re-work to reduce the number of CSS entries you have if you want to simplify.
Feel free to take a look at my solution to compare. I spent quite a bit of time trying to build it in line with feedback the community gave me on my previous solution. They gave a lot of good tips on responsiveness, readability, accessibility etc.
Marked as helpful1 - @bricard-devSubmitted 3 months ago
- @pedro-10-vieiraSubmitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
The main challenge in this project was to recreate the preview's font-sizes and dimensions only by eye.
What specific areas of your project would you like help with?If there is a more optimal/clean solution, I would like to receive some feedback :)
@dearestalexanderPosted 3 months agoHi Pedro, your design looks good. All the element spacing seems a good match.
Overall size looks a bit smaller, but exactly the same happened with me, after first submission I increased my height and width a bit to get a good match.
Marked as helpful1 - @muradmaharramlySubmitted 3 months ago@dearestalexanderPosted 3 months ago
Hello, your colours, font and size look good. I think you could adjust to centre the white outline on the page in line with the sample. There's a fairly easy way to centre on the page using a combination of absolute position, top, left and transform.
Marked as helpful0
