Skip to content
OverviewSolutions
3
Comments
3
Dany DA GRAÇA
@ddg-dev

All comments

  • Kaloyan Kostov•60
    @Kaloyan-KostovSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    All went good this time.

    What challenges did you encounter, and how did you overcome them?

    The main img was not being displayed at all.

    Social Links Profile

    1
    Dany DA GRAÇA•50
    @ddg-devPosted 3 months ago
    • Does the solution include semantic HTML? Yes, but I think that could be more simple (more precisely concerning the section id "card" and the header tag).
    • Is it accessible, and what improvements could be made? Yes, it is.
    • Does the layout look good on a range of screen sizes? Your website doesn't centered on mobile screen.
    • Is the code well-structured, readable, and reusable? I think you can do it more simple.
    • Does the solution differ considerably from the design? It differs a little (looking the gap around the social links buttons and titles).

    Why do you put @font-face two times in your CSS file ? One is enough and you can modify the font-weight in concerning classes.

    1
  • ilyesfennour•60
    @ilyesfennourSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    it was an easy challenge

    What challenges did you encounter, and how did you overcome them?

    The challenge was to add an inner border, which I solved by adding outline and outline-offset.

    Responsive Blog preview card

    1
    Dany DA GRAÇA•50
    @ddg-devPosted 3 months ago
    • Does the solution include semantic HTML? No, only using div.
    • Is it accessible, and what improvements could be made? Yes, it's ok on desktop and mobile.
    • Does the layout look good on a range of screen sizes? Yes.
    • Is the code well-structured, readable, and reusable? Yes.
    • Does the solution differ considerably from the design? It's perfectly the same !

    Care about the hover on the title HTML & CSS foundations. The hover is active around the title not on the title.

    Marked as helpful
    1
  • Dany DA GRAÇA•50
    @ddg-devPosted 3 months ago

    Not using semantic HTML. The favicon is disabled. Why you use Express and Node for this ? None script linked in your index.html.

    I can't see the live version of the page. For the rest, i think it is good.

    0