Skip to content
OverviewSolutions
10
Comments
3
Bosca Darius
@dariuss1123

All comments

  • Bosca Darius•120
    @dariuss1123Posted over 1 year ago

    hello. great job for the solution.

    However, if you want to center your card you can make the body a flexbox and apply a height of 100vh. and then you can apply justify-content: center and align-content: center. This will place your card component in the center of the page.

    Hope this was helpful. Happy coding!

    Marked as helpful
    1
  • Bosca Darius•120
    @dariuss1123Posted over 1 year ago

    Great job on making this solution. It looks pretty similar to the design.

    I would only suggest you use a div for the entire card called container or card and this way you can manipulate it better. And you can center it to be aligned with the .attribution by giving it a max-width and setting margin to 0 auto.

    I'm a beginner too so i won't try to go deeper into the code:))) anyway, keep it up and happy coding!

    0
  • Bosca Darius•120
    @dariuss1123Posted over 1 year ago

    Great job. I can barely see any difference between the design and your solution. -I'm a beginner too but I would suggest you try using responsive units like em and rem instead of px for best practice and responsiveness.

    -And for margin i would suggest you use the margin: shorthand instead of margin-right:, margin-left: etc.

    But all these aside you did a good job getting that design done! Good luck in the future and happy coding!

    0