feedback would be appreciated!!
dannxvc
@dannxvcAll comments
- @a2uuzSubmitted over 2 years ago@dannxvcPosted over 2 years ago
Hi! It looks so good. I think you should use the
form
markup instead ofdiv
, so your card would be actually accessible. Also you could change yourbuttons
for radio buttons, and your submit button should have asubmit
type attribute. Finally, this article might help you styling your radio buttons without losing accessibility. Hope this helps :)Marked as helpful0 - @carlosegs1506Submitted over 2 years ago
Me costo un poco pero quedo bien agradezco algún comentario.
@dannxvcPosted over 2 years agoHi! So far so good, you should change the
h1
tags forp
tags, because it's best practice to have only oneh1
tag per page, you can read more about this in this article . That's why you got 6 html issues. Also you could change yourp
tags you used for every name toh2
tags. Hope it helps :)Marked as helpful0 - @ApplePieGiraffeSubmitted over 2 years ago
Hey, everybody! 👋
This was a fun challenge in which I learned how to use and style the
<details>
and<summary>
HTML elements.I also added a bobbing animation to the floating cube (with a small touch from the
drop-shadow
CSS function) and animated thelinear-gradient
background with this helpful tool.I'm quite happy with the result! 😊
Any feedback on both the design and code is welcome and appreciated! 😃
Happy coding! 😁
EDIT: For some reason, the details marker on each of the FAQs is showing up in the screenshot (even though I set their
display
tonone
) but they're gone on the actual page, as far as I can tell.@dannxvcPosted over 2 years agoOh this so amazing!!! I truly love this, you are so creative. I think I would change the card's
height
asmin-height
, so then if all of your questions are opened, they could be seen and to make your cube-img look as good as it does now, you could position it by usingtop:40%
andtransform: translateY(50%)
, that would be sick. Amazing job as always!Marked as helpful2 - @MinaEssa-SolimanSubmitted over 2 years ago@dannxvcPosted over 2 years ago
Hi so far so good!! I recommend you to follow the readme file instructions, for you to have a readme about your actual proyect. Also, I'd say you should use the right font weights, so it'll look more like the original design, you could read more about it here.
Marked as helpful0