Dan Marius
@danmlarsen
All comments
- PDan Mariusโข 625
@danmlarsen
Posted
Hello there. Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
I've made one observation that might interest you:
- The borders on your nav links seems to push the other elements 2 pixels down when hovered. One solution to this might be to add "border-b-2" and "border-transparent" to all the links. And then just "hover:border-white" when hovered.
Happy coding. ๐ป
Dan
Marked as helpful
0 - mofadaโข 310
@mofada
Submitted
PDan Mariusโข 625@danmlarsen
Posted
Hello, mofada! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
0 - PSam Hookerโข 410
@35degrees
Submitted
What are you most proud of, and what would you do differently next time?
I am improving my use of semantic HTML and adding roles for accessibility. I am understanding better how tab-indexing works and including it in my functionality. I feel like I leveled up on this project and I'm getting faster and more confident in my coding.
What challenges did you encounter, and how did you overcome them?
Lightbox was a challenge to add to the finished site, fun to learn. Lots of JS tricks implemented and a lot of media changes in the mobile version.
What specific areas of your project would you like help with?
a11y and ARIA headers.
PDan Mariusโข 625@danmlarsen
Posted
Hello there. Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
I've made one accessibility observation that might interest you:
- When I hover one of the thumbnails the main image seems to be removed, which is somewhat confusing. I think the problem is somwhere in the updateMainPhoto function. All image urls seems to go to: "https://github.com/35degrees/ecommerce-landing-a11y-fem20/blob/main/images/image-pro"
Happy coding. ๐ป
Dan
Marked as helpful
0 - liquid waterโข 330
@liquidwater0
Submitted
PDan Mariusโข 625@danmlarsen
Posted
Hello, liquid water! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
0 - Sonja Krafftโข 310
@sonmikrafft
Submitted
What are you most proud of, and what would you do differently next time?
Using a data.json for the text, making the code maintainable, Adding a design for small laptop sizes
PDan Mariusโข 625@danmlarsen
Posted
Hello there. Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
I've made one observation that might interest you:
- On the upper screen width the site starts getting quite stretched (1920 and beyond). I suggest putting a max-width on the header and main elements to fix this.
Happy coding. ๐ป
Dan
0 - PBartosz Dudziakโข 510
@bartoszdudziak-dev
Submitted
What are you most proud of, and what would you do differently next time?
- Generally I am proud of that it works ๐ Except that I feel it should looks a lot better
- Next time I would use ready components and create better structure of my code
- I have just wanted to make it works cuz of I started to getting lost in my code
What challenges did you encounter, and how did you overcome them?
- The most difficulty was to style input of type range and checkboxes because of their weird basic behaviour
- I had to find some information about webkits and etc.
- I created very simple algorithm which rate password strength, it definitely needs a improvement
What specific areas of your project would you like help with?
Leave your opinion about anything you think about my solution. Thanks ๐ซก
PDan Mariusโข 625@danmlarsen
Posted
Hello, Bartosz Dudziak! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
I only have one suggestion:
- The slider seems to have a few issues on the firefox browser. You probably just need to make a few adjustments on the ::-moz-range-thumb and it will be perfect ๐
Happy coding. ๐ป
Dan
Marked as helpful
0 - Danil_Dikhtyar ๐ฅโข 200
@Rock-n-Roll-CRC
Submitted
What are you most proud of, and what would you do differently next time?
This project is built with remarkable attention to:
- Project arcitecture
- Meta data, including OpenGraph and TwitterCard
- Semantic HTML elements
- Accessibility using aria attributes
- Well documented code
- Separation of concerns, splitting SCSS into different partials and TypeScript into different modules
What specific areas of your project would you like help with?
Lighthouse says that setting
aria-required="true"on a fieldset, containing multiple radio inputs is invalid, but how would I let the browser know that selecting at least one of the radio buttons inside that fieldset is actually required for the form to be submitted?PDan Mariusโข 625@danmlarsen
Posted
Hello, Danil! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
1 - Sonja Krafftโข 310
@sonmikrafft
Submitted
What are you most proud of, and what would you do differently next time?
I used a data.json to store questions and answers. This makes the code more maintainable.
What challenges did you encounter, and how did you overcome them?
I don't particularly appreciate it when there is a clear button, but the question is also clickable. So, I just refused to do it.
PDan Mariusโข 625@danmlarsen
Posted
Hello there. Congratulations on finishing another challenge! Your solution mostly responds quite well and looks nice ๐
I've just made a few observations that might interest you:
- The site seems to not be functional on firefox. I just get an console error.
- The background image breaks between mobile and desktop. A quick fix would be to add background-size: contain to your container class
0 What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?
.
What specific areas of your project would you like help with?
.
PDan Mariusโข 625@danmlarsen
Posted
Hello, Mikhail! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
0- PPurnama S Rahayuโข 250
@catreedle
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of pushing through this challenge. I need to take some time to learn more about grid.
What challenges did you encounter, and how did you overcome them?
Grid.
What specific areas of your project would you like help with?
understanding grid and writing clean JS.
PDan Mariusโข 625@danmlarsen
Posted
Hello there. Good job on completing the challenge! ๐
I only have one suggestion for you:
- Between the mobile (375px) and desktop (1440px) resolutions the site seems to break. Perhaps it would be worthwhile to make a tablet/small desktop breakpoint as well. I suggest at around 768px
Marked as helpful
0 - kerekiwereโข 350
@kerekiwere
Submitted
PDan Mariusโข 625@danmlarsen
Posted
Hello, kerekiwere! ๐
Congratulations on finishing another challenge! Your solution responds quite well and looks nice ๐
1 - kerekiwereโข 350
@kerekiwere
Submitted
PDan Mariusโข 625@danmlarsen
Posted
Well-structured code with effective use of semantic tags. A great solution to the challenge ๐
1
