Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @mehmetfatihdurna

    Submitted

    What are you most proud of, and what would you do differently next time?

    I completed this challenge with a design almost identical to the one in Figma. I am proud of myself for that. But my codes are so confusing. I am going to learn clean code techniques.

    What challenges did you encounter, and how did you overcome them?

    I didn't know how can i control inputs. I was only asking users to enter numbers. Then i realized input tags have onInput attribute. Then i wrote this function:

    function inputControl(e){
            e.target.value = e.target.value.replace(/[^0-9]/,'');
        }
    
    
        
    
    

    I made sure that users could only enter numbers with this function.

    @danielchavezs

    Posted

    It looks really good, and state management seems to be working great as well. I woud probably only advice you to change the functionality of the "Clear All" button as it is recharging the whole page; take advantage of Vite - React, as you are already doing it in other features to keep it running as a SPA without unnecesary page reloads. Kuddos for the great work!

    1
  • @danielchavezs

    Posted

    Container and qr image sizing is on point. But do check the spaces (probably use span) between the image, the text and the spaces around them. Also check the text colors :)

    0