Skip to content
OverviewSolutions
9
Comments
5
Dan
@dan9h

All comments

  • Dan•210
    @dan9hPosted 9 months ago

    Your solutions looks great!

    There's just a bit of a problem with the validation. It should not accept a valid future date.

    Ex:

    Current Date: 15-2-2024
Input Date: 16-2-2024 (just a day ahead but still valid)
Result: -1 years

    I'm pretty confident you can fix it.

    Happy Coding!

    Marked as helpful
    0
  • Rafael Dias•910
    @rafaeldgeoSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud by create the layout using the correct HTML semantic. Tag is used in actions, while tag is used to link pages.

    What challenges did you encounter, and how did you overcome them?

    I didn't have problems.

    What specific areas of your project would you like help with?

    I would like to help in the use of correct HTML semantic.

    social-links-profile-main using flexbox and grid

    2
    Dan•210
    @dan9hPosted 9 months ago

    Hey there! Your solution looks great. I just have a few suggestions.

    Try to use <ul> or <menu> tag for the social links.

    Example:

    <ul>
  <li>
    <a href="#">Link 1</a>
  </li>
  <li>
    <a href="#">Link 2</a>
  </li>
  <li>
    <a href="#">and so on</a>
  </li>
</ul>

    Also, add some class or id selectors to your HTML tags, so you can target and style specific elements with CSS.

    Hope you'll find this helpful.

    Marked as helpful
    1
  • Harrison-Jolly•30
    @Harrison-JollySubmitted 9 months ago

    I have one main question.

    How do I get the numbered list to have a gap between the numbers and the text?

    I tried a few different things but in the end I couldn't find a solution so I moved on.

    A part from that I'm just looking for tips and tricks to simplify my code and make it neater. For example the nutrition table at the bottom. I'm interested to see how everyone else did theirs!

    Responsive Recipe Page

    3
    Dan•210
    @dan9hPosted 9 months ago

    Hey there! Congratulations on completing your first challenge.

    text-indent only indents the first line of the text/paragraph. You should use either padding-left or padding-inline-start for spacing.

    You can try the following:

    ol li {
    padding-left: 20px;
}

    or

    ol li {
    padding-inline-start: 20px;
}

    You can remove position: relative; and margin-left: 25px. They have no effect to the layout.

    And for the nutrition table, well, you can use a <table>. 😂 If this element's new to you, check this very helpful MDN article about HTML Tables.

    Hope this helps!

    Marked as helpful
    1
  • Dan•210
    @dan9hPosted over 1 year ago

    Your preview site link is incorrect. Seems that you've mistakenly added the solution for the QR code component challenge.

    Marked as helpful
    0
  • Dan•210
    @dan9hPosted over 1 year ago

    Check this out -> Centering in CSS

    This is a great resource for centering an element in CSS.

    0